Skip to content

Only check tags expected to have types for no-undefined-types and valid-types #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented May 17, 2019

  • Optimization: For no-undefined-types, only check tags expected to have types (as with check-types) or, for valid-types, tags expected to have types or namepaths
  • Docs: For valid-types, indicate this grouping of name(path) defining vs. pointing tags

Fixes part of #233.

@brettz9 brettz9 requested a review from gajus May 17, 2019 01:36
@brettz9 brettz9 force-pushed the limit-type-checking-to-known-type-tags branch from ea8d3b7 to d3aa406 Compare May 17, 2019 04:37
… have types (as with `check-types`) or, for `valid-types`, tags expected to have types or namepaths

- Docs: For `valid-types`, indicate this grouping of name(path) defining vs. pointing tags
@brettz9 brettz9 force-pushed the limit-type-checking-to-known-type-tags branch from d3aa406 to 18ca406 Compare May 17, 2019 05:11
@brettz9 brettz9 merged commit eeea948 into gajus:master May 17, 2019
@brettz9 brettz9 deleted the limit-type-checking-to-known-type-tags branch May 17, 2019 07:13
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants