Skip to content

npm updates #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 17, 2019
Merged

npm updates #237

merged 1 commit into from
May 17, 2019

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented May 17, 2019

  • npm: Update devDeps and peerDep (breaking change?)
  • Linting: Disable two new rules; prefer includes

I ran npm-check-updates and found the devDep items in the PR ready for updates.

It also updated the peerDependency, eslint. I don't know if you'd consider that a breaking change, since it will probably only alert users rather than require them to use eslint 5, but I figure it may be time for a change?

- Linting: Disable two new rules; prefer `includes`
@brettz9 brettz9 requested a review from gajus May 17, 2019 07:43
@gajus
Copy link
Owner

gajus commented May 17, 2019

Not a breaking change. Good to proceed.

@brettz9 brettz9 merged commit 336589d into gajus:master May 17, 2019
@brettz9 brettz9 deleted the update-devDeps branch May 17, 2019 08:23
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants