Skip to content

Add CONTRIBUTING.md file for #180 #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2019
Merged

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented May 17, 2019

No description provided.

@brettz9
Copy link
Collaborator Author

brettz9 commented May 17, 2019

By the way, @gajus , re: linting, are you interested in trying out my eslint-config-ash-nazg config (if I adapt it to preserve your existing styles)? We are using it in svgedit, and I'm using it in a number of other projects and finding it very helpful in catching a lot of bugs missed by other configs. (It is a combination of various configs, including "standard", "node", "import", and your plugin among others.)

@gajus
Copy link
Owner

gajus commented May 17, 2019

re: linting, are you interested in trying out my eslint-config-ash-nazg config (if I adapt it to preserve your existing styles)? We are using it in svgedit, and I'm using it in a number of other projects and finding it very helpful in catching a lot of bugs missed by other configs. (It is a combination of various configs, including "standard", "node", "import", and your plugin among others.)

No. All my projects use the same ESLint config. But, if there are any styles missing in https://github.com/gajus/eslint-config-canonical that you see worth adding, then please go ahead and contribute. Canonical stylesheet has been maintained for more than 3 years now and it is being used by large development teams.

@brettz9 brettz9 force-pushed the contributing branch 3 times, most recently from 69bca6b to 3a3278a Compare May 17, 2019 12:12
@brettz9 brettz9 requested a review from gajus May 19, 2019 15:06
@brettz9 brettz9 merged commit e35c858 into gajus:master May 19, 2019
@brettz9 brettz9 deleted the contributing branch May 19, 2019 16:23
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants