Skip to content

- Add meta.type #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2019
Merged

- Add meta.type #244

merged 1 commit into from
May 21, 2019

Conversation

brettz9
Copy link
Collaborator

@brettz9 brettz9 commented May 21, 2019

As per https://eslint.org/docs/developer-guide/working-with-rules#rule-basics .

Not sure how this may be surfaced, but figure it doesn't hurt to document it.

@brettz9 brettz9 requested a review from gajus May 21, 2019 06:32
@brettz9 brettz9 mentioned this pull request May 21, 2019
@brettz9
Copy link
Collaborator Author

brettz9 commented May 21, 2019

And I see now that it does already have practical utility; per https://eslint.org/docs/user-guide/command-line-interface , one can call eslint with --fix-type Array to choose whether to apply fixes to "problem", "suggestion", and/or "layout".

Note too that I didn't label any of our issues as "problem" (even though bad jsdoc's could potentially signal a problem), since I wasn't sure you'd want say invalid types to be, as per https://eslint.org/docs/developer-guide/working-with-rules#rule-basics , "identifying code that either will cause an error or may cause a confusing behavior". I can change some of the rules to "problem" though if you think the criteria is met.

@brettz9 brettz9 merged commit 02c2b22 into gajus:master May 21, 2019
@brettz9 brettz9 deleted the meta.type branch May 21, 2019 07:59
@gajus
Copy link
Owner

gajus commented May 21, 2019

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants