-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(apple): Docs for enableMetricKitRawPayload #10334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apple): Docs for enableMetricKitRawPayload #10334
Conversation
Add docs for enableMetricKitAttachments available on Cocoa 8.29.0 and above.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Bundle ReportChanges will increase total bundle size by 15.54kB ⬆️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding this 🙏 left a comment about the code snippets.
also do you have an idea how large these attachments can get, or how frequent? basically an idea for us and the user how this could affect attechment quotats
Co-authored-by: Karl Heinz Struggl <[email protected]>
Co-authored-by: Karl Heinz Struggl <[email protected]>
That's really hard to say. Our attachments in our test app are usually around a couple of KBs, but I have no idea what that looks like for large apps with more data. |
Ok couple of KBs seems fine, also I assume he number of attachments will scale with the number of MetricKit issues, and it's opt-in, so sgtm. |
DESCRIBE YOUR PR
Add docs for enableMetricKitAttachments available on Cocoa 8.29.0 and above.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: