Skip to content

fix(apple): Docs for enableMetricKitRawPayload #10334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jun 10, 2024

DESCRIBE YOUR PR

Add docs for enableMetricKitAttachments available on Cocoa 8.29.0 and above.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Add docs for enableMetricKitAttachments available on Cocoa 8.29.0 and
above.
Copy link

vercel bot commented Jun 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 10:04am

Copy link

codecov bot commented Jun 10, 2024

Bundle Report

Changes will increase total bundle size by 15.54kB ⬆️

Bundle name Size Change
sentry-docs-server 7.52MB 15.55kB ⬆️
sentry-docs-edge-server 475.14kB 3 bytes ⬇️
sentry-docs-client 6.21MB 10 bytes ⬇️

@philipphofmann philipphofmann requested a review from a team June 10, 2024 08:59
@philipphofmann philipphofmann changed the title fix(apple): Docs for enableMetricKitAttachments fix(apple): Docs for enableMetricKitRawPayload Jun 10, 2024
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this 🙏 left a comment about the code snippets.

also do you have an idea how large these attachments can get, or how frequent? basically an idea for us and the user how this could affect attechment quotats

@philipphofmann
Copy link
Member Author

also do you have an idea how large these attachments can get, or how frequent? basically an idea for us and the user how this could affect attechment quotats

That's really hard to say. Our attachments in our test app are usually around a couple of KBs, but I have no idea what that looks like for large apps with more data.

@kahest
Copy link
Member

kahest commented Jun 10, 2024

also do you have an idea how large these attachments can get, or how frequent? basically an idea for us and the user how this could affect attechment quotats

That's really hard to say. Our attachments in our test app are usually around a couple of KBs, but I have no idea what that looks like for large apps with more data.

Ok couple of KBs seems fine, also I assume he number of attachments will scale with the number of MetricKit issues, and it's opt-in, so sgtm.

@stephanie-anderson stephanie-anderson merged commit b356998 into master Jun 14, 2024
6 checks passed
@stephanie-anderson stephanie-anderson deleted the feat/enable-metric-kit-attachments branch June 14, 2024 08:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants