Skip to content

Add background to inline code blocks in headings #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Jun 19, 2024

DESCRIBE YOUR PR

  • Adds a background to inline code blocks in headings
  • Adds style guide colors
  • Prevent line wrapping of inline code blocks in headings
  • Reduce font weight to be in line with style guide

Fixes #10426

Before:

Screenshot 2024-06-19 at 14 17 01

After:

Screenshot 2024-06-19 at 14 16 43

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

Copy link

vercel bot commented Jun 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 0:52am

@lforst lforst requested review from cleptric and s1gr1d June 19, 2024 12:17
Copy link

codecov bot commented Jun 19, 2024

Bundle Report

Changes will increase total bundle size by 313 bytes ⬆️

Bundle name Size Change
sentry-docs-server 7.55MB 27 bytes ⬆️
sentry-docs-client 6.22MB 259 bytes ⬆️
sentry-docs-edge-server 479.46kB 27 bytes ⬆️

@lforst lforst enabled auto-merge (squash) June 19, 2024 12:22
@lforst lforst disabled auto-merge June 19, 2024 12:22
@lforst lforst enabled auto-merge (squash) June 19, 2024 12:26
@lforst lforst merged commit cdd6673 into master Jun 19, 2024
6 checks passed
@lforst lforst deleted the lforst-better-inline-code-in-headings branch June 19, 2024 12:52
@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inlinde code tags in headings look weird
4 participants