Skip to content

feat(python): Add disabled_integrations config option #10808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Jul 23, 2024

DESCRIBE YOUR PR

With getsentry/sentry-python#3166 we're adding a new config option to the Python SDK. Most of our integrations are now auto-enabled, making it harder to opt out of single integrations. disabled_integrations solves this issue.

Preview:

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): July 23
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 24, 2024 7:42am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jul 24, 2024 7:42am

Copy link

codecov bot commented Jul 23, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 9.53MB 6 bytes ⬇️
sentry-docs-edge-server 255.36kB 3 bytes ⬇️
sentry-docs-client 8.18MB 6 bytes ⬇️

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! I just have a few small suggestions.

@sentrivana sentrivana enabled auto-merge (squash) July 24, 2024 07:27
@sentrivana sentrivana merged commit 12dd357 into master Jul 24, 2024
8 checks passed
@sentrivana sentrivana deleted the ivana/python/disabled-integrations branch July 24, 2024 07:42
lforst pushed a commit that referenced this pull request Jul 24, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants