Skip to content

docs(nuxt): Add Nuxt docs for manual setup #10981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 9, 2024
Merged

docs(nuxt): Add Nuxt docs for manual setup #10981

merged 8 commits into from
Aug 9, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Aug 5, 2024

DESCRIBE YOUR PR

Adding manual setup docs for Nuxt. There is no wizard script yet, so all manual setup instructions are added to the "getting started" instead of an extra "Manual Setup".

closes getsentry/sentry-javascript#13239

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): 6. August
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

Copy link

vercel bot commented Aug 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 8:00am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 9, 2024 8:00am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 9, 2024 8:00am

@s1gr1d s1gr1d requested review from lizokm, mydea, Lms24 and andreiborza and removed request for mydea August 5, 2024 15:38
Copy link

codecov bot commented Aug 5, 2024

Bundle Report

Changes will increase total bundle size by 9.86kB ⬆️

Bundle name Size Change
sentry-docs-server 8.26MB 4.94kB ⬆️
sentry-docs-edge-server 253.05kB 3 bytes ⬇️
sentry-docs-client 6.25MB 4.93kB ⬆️

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple suggestions, but overall, looks good! Thanks for adding!

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs! I had some wording suggestions but feel free to apply them liberally or go with your own version. General idea: Try to keep things concise and opinionated, especially in the main "Getting Started" page. I think this is already in a good state.

Also (not for this PR but I got reminded) we need to add Nuxt to our platform icons package to get the fancy logo :)

<template>
<button id="errorBtn" @click="triggerError">Trigger Error</button>
</template>
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: Theoretically we could also show them how to capture an error on the server side. Not a high-prio task though, feel free to tackle later or ignore :)

Comment on lines 6 to 7
To upload source maps, you need to specify your Sentry auth token as well as your org and project slugs. You can specify those in the `sourceMapsUploadOptions` option
inside the `sentry` options of your `nuxt.config.ts`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l: l: I'd use "you can" formulations sparingly. Our general "voice"/mentality is that we are opinionated and tell people what they should do to get the SDK set up.

Suggested change
To upload source maps, you need to specify your Sentry auth token as well as your org and project slugs. You can specify those in the `sourceMapsUploadOptions` option
inside the `sentry` options of your `nuxt.config.ts`.
To upload source maps, specify your Sentry auth token as well as your org and project slugs. Set them in the `sourceMapsUploadOptions` option
inside the `sentry` options of your `nuxt.config.ts`.

(I'm aware that we're probably having similar wording in countless places but I think we should try to be more concise and straight forward when we have the chance)

(Also if someone from docs teams sees this differently, please feel free to roast me :D)

Comment on lines 55 to 56
2. Add an import flag to the `NODE_OPTIONS` of your `nuxt preview` in `package.json`, so the file loads before any
other imports:
Copy link
Member

@Lms24 Lms24 Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

m: I'd probably word this a bit differently because it's not just about their preview command but also where people actually deploy their app.

Something along the lines of

Suggested change
2. Add an import flag to the `NODE_OPTIONS` of your `nuxt preview` in `package.json`, so the file loads before any
other imports:
2. Add an `--import` flag to the `NODE_OPTIONS` environment variable wherever you run your application. For example, for local previews, adjust your `package.json` script:

Then, below the code snippet we could add a sentence like

"Make sure to also add this environment variable in your deployment environment, for example on Vercel or Netlify"

@s1gr1d s1gr1d self-assigned this Aug 7, 2024
s1gr1d and others added 4 commits August 8, 2024 10:53
@s1gr1d s1gr1d merged commit 450cdfb into master Aug 9, 2024
11 checks passed
@s1gr1d s1gr1d deleted the sig/nuxt-docs branch August 9, 2024 08:30
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Docs for Nuxt
3 participants