Skip to content

fix(cocoa): Last good SDK version before release info issue #11033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

kahest
Copy link
Member

@kahest kahest commented Aug 8, 2024

DESCRIBE YOUR PR

Fixes last good SDK version before the bug was introduced that causes release health to miss "Unhandled" issues. See #11017

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.): asap since we want to link to this doc from an in-product info notification we show to affected users
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

EXTRA RESOURCES

@kahest kahest requested a review from philipphofmann August 8, 2024 18:05
Copy link

vercel bot commented Aug 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 6:18pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 6:18pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Aug 8, 2024 6:18pm

Copy link

codecov bot commented Aug 8, 2024

Bundle Report

Changes will increase total bundle size by 8.51MB ⬆️

Bundle name Size Change
sentry-docs-server 8.25MB 8.25MB ⬆️
sentry-docs-edge-server 254.16kB 254.16kB ⬆️
sentry-docs-client 6.24MB 6 bytes ⬇️

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kahest kahest merged commit cc10f25 into master Aug 8, 2024
9 checks passed
@kahest kahest deleted the kahest/fix-cocoa-release-bug-version branch August 8, 2024 18:25
@philipphofmann
Copy link
Member

Thank you @kahest 💯

@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants