-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix(apple): Add reasons for watchdog terminations #11460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Explain that some crashes might lead to watchdog termination events.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
…s.mdx Co-authored-by: Karl Heinz Struggl <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the additional clarification 🙏
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
docs/platforms/apple/common/configuration/watchdog-terminations.mdx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggested edits, overall LGTM! 👍
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
…s.mdx Co-authored-by: Alex Krawiec <[email protected]>
DESCRIBE YOUR PR
Explain that some crashes might lead to watchdog termination events.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: