Skip to content

feat(dashboards): Update Widget Builder doc to include Big Number Equations #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

harshithadurai
Copy link
Contributor

@harshithadurai harshithadurai commented Oct 1, 2024

DESCRIBE YOUR PR

Update Widget Builder doc to include new Equations feature for Big Number Widgets.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 2:32pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 2:32pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 2, 2024 2:32pm

Copy link

codecov bot commented Oct 1, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.45MB 6 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.07kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.42MB 6 bytes (-0.0%) ⬇️

@harshithadurai
Copy link
Contributor Author

harshithadurai commented Oct 1, 2024

Don't think I need to specifically mention equations for Big Number here since this section already talks about equations in a general sense that also applies well to Big Numbers

@narsaynorath
Copy link
Member

QQ, I see this is set to Draft so I just wanted to check, are you planning to update the general guidelines of adding an equation in this PR as well?

@harshithadurai harshithadurai marked this pull request as ready for review October 2, 2024 13:51
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, let's wait until we start releasing to EA (tomorrow) to merge this

@coolguyzone coolguyzone self-requested a review October 2, 2024 16:25
@harshithadurai harshithadurai merged commit 94bbae5 into master Oct 3, 2024
10 checks passed
@harshithadurai harshithadurai deleted the harshi/add-big-number-equations branch October 3, 2024 16:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants