Skip to content

Added new options to control what frames to add to the stack trace #11844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

antonpirker
Copy link
Member

DESCRIBE YOUR PR

Documentation of two new options that where introduced here: getsentry/sentry-python#3673

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 4:10pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 4:10pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 4:10pm

Copy link

codecov bot commented Nov 16, 2024

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.6MB 9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 8.94MB 6 bytes (-0.0%) ⬇️

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding!

@antonpirker antonpirker marked this pull request as ready for review December 6, 2024 15:50
@antonpirker antonpirker enabled auto-merge (squash) December 6, 2024 15:50
@antonpirker antonpirker merged commit 217b4d3 into master Dec 6, 2024
11 checks passed
@antonpirker antonpirker deleted the antonpirker/python/track-frame-options branch December 6, 2024 16:10
Lms24 pushed a commit that referenced this pull request Dec 13, 2024
…11844)

Documentation of two new options that where introduced here: getsentry/sentry-python#3673

---------

Co-authored-by: Liza Mock <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants