feat(develop): Propose new discard reason for buffer overflow #12395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
This was referenced Jan 20, 2025
coolguyzone
approved these changes
Jan 21, 2025
AbhiPrasad
added a commit
to getsentry/snuba
that referenced
this pull request
Jan 21, 2025
ref getsentry/team-sdks#116 This PR implements a new client discard reason for `buffer_overflow`. This will be used to track when the internal breadcrumbs buffer overflows for the new logs product that we are working on. This is documented in develop here: getsentry/sentry-docs#12395 I also went ahead and added code comments that describes what all the different client discard reasons mean. This is done in commit b3dcd67, while the actual change to add the `buffer_overflow` discard reason was added in dd25dde. Note: The reason we have `buffer_overflow` as a separate item to `queue_overflow` is that in the future when we send log items in envelopes we'll increment `queue_overflow` for the transport queue. We want to differentiate between the transport queue and the internal buffer explicitly. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 23, 2025
ref getsentry/team-sdks#116 This PR implements a new client discard reason for `buffer_overflow`. This will be used to track when the internal breadcrumbs buffer overflows for the new logs product that we are working on. This is documented in develop here: getsentry/sentry-docs#12395 Note: The reason we have `buffer_overflow` as a separate item to `queue_overflow` is that in the future when we send log items in envelopes we'll increment `queue_overflow` for the transport queue. We want to differentiate between the transport queue and the internal buffer explicitly.
AbhiPrasad
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Jan 23, 2025
ref getsentry/team-sdks#116 This PR implements a new client discard reason for `buffer_overflow`. This will be used to track when the internal breadcrumbs buffer overflows for the new logs product that we are working on. This is documented in develop here: getsentry/sentry-docs#12395 Note: The reason we have `buffer_overflow` as a separate item to `queue_overflow` is that in the future when we send log items in envelopes we'll increment `queue_overflow` for the transport queue. We want to differentiate between the transport queue and the internal buffer explicitly.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref getsentry/team-sdks#116
My prettier formatted this page, but the main change is to add
buffer_overflowas a discard reason.The reason we have
buffer_overflowas a separate item toqueue_overflowis that in the future when we send log items in envelopes we'll incrementqueue_overflowfor the transport queue. We want to differentiate between the transport queue and the internal buffer explicitly.After this we need to add the reason to snuba as a new client discard reason.