Skip to content

feat(dart & flutter): add data collected page and sendDefaultPii to getting started #12787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 20, 2025

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Feb 20, 2025

DESCRIBE YOUR PR

Add details about data collection and the sendDefaultPii flag to the getting started

closes getsentry/sentry-dart#2692
closes getsentry/sentry-dart#2691

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 4:34pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 4:34pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Feb 20, 2025 4:34pm

@buenaflor buenaflor requested a review from kahest February 20, 2025 13:19
Copy link

codecov bot commented Feb 20, 2025

Bundle Report

Changes will increase total bundle size by 408 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB 414 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
server/middleware-*.js -5.55kB 1.0kB -84.74%
server/middleware-*.js 5.55kB 6.55kB 555.3% ⚠️
static/zIANg9EevLs7yyO87SxlI/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/zIANg9EevLs7yyO87SxlI/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/B5kwTEaNOs0w0Im1t8MLS/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/B5kwTEaNOs0w0Im1t8MLS/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️
view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
../app/[[...path]]/page.js.nft.json 141 bytes 379.18kB 0.04%
../app/platform-redirect/page.js.nft.json 141 bytes 379.09kB 0.04%
../app/sitemap.xml/route.js.nft.json 141 bytes 377.06kB 0.04%

Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 links seem incorrect, otherwise lgtm

just to double-check - there's a lot of overlap with the Android docs on the topic - is this because a lot of this is based on native impls? and if so, does sentry-cocoa handle things the same way, e.g. guard same data with sendDefaultPii?

@buenaflor
Copy link
Contributor Author

buenaflor commented Feb 20, 2025

is this because a lot of this is based on native impls

The only thing here that comes from native is the device information, the rest is identical in terms of how it is guarded implemented in Dart, so I just used the existing android docs and added a couple of items on top

But I looked it up and seems like device.name is always added on Cocoa, so we might have to change the wording a bit, maybe something along the lines of Depending on the platform, device names may only be sent with sendDefaultPii = true or something like that?

@buenaflor
Copy link
Contributor Author

buenaflor commented Feb 20, 2025

@kahest after guarding the Platform.localhostName (which is currently the default if we dont get any other device name from e.g native) with sendDefaultPii I think the current wording will be correct

@buenaflor buenaflor enabled auto-merge (squash) February 20, 2025 16:24
@buenaflor buenaflor merged commit d5cd117 into master Feb 20, 2025
11 checks passed
@buenaflor buenaflor deleted the buenaflor-patch-2 branch February 20, 2025 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document data collected by SDKs Document and add sendDefaultPii: true to onboarding docs
2 participants