Skip to content

ref(flags): mention is_enabled method for Unleash eval tracking #12794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Feb 20, 2025

Our Unleash implementation patches the is_enabled/isEnabled method only. Let's mention this method to avoid potential confusion.

is_enabled is the main way users evaluate boolean flags, but you could technically use the result of get_variant too. We chose not to support the latter which is explained in depth on getsentry/sentry-python#3914

Copy link

vercel bot commented Feb 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2025 8:12pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Feb 20, 2025 8:12pm
develop-docs ⬜️ Ignored (Inspect) Feb 20, 2025 8:12pm

Copy link

codecov bot commented Feb 20, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.94MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.39MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.71MB -0.0%
../instrumentation.js -3 bytes 1.04MB -0.0%
9523.js -3 bytes 1.02MB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 865.35kB -0.0%
static/chunks/1298-*.js -3 bytes 401.61kB -0.0%
static/PbkPIQ2Bmmvxo6bV1bmKj/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/PbkPIQ2Bmmvxo6bV1bmKj/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/aGJcAFeR_hmeQSJThi2uk/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/aGJcAFeR_hmeQSJThi2uk/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@aliu39 aliu39 merged commit b1305be into master Feb 20, 2025
11 checks passed
@aliu39 aliu39 deleted the aliu/eval-track-fxs branch February 20, 2025 20:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants