You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a copy to clipboard button for highlighted line groups within a code block.
Why? In larger code examples, I find the main copy to clipboard button impractical because it copies a lot of code that's already there. So most of the time, it's unusable for me, making me have to highlight and select the appropriate code parts anyway. Since we can highlight the important code parts, this has already gotten much easier. But I think we can go a step further and offer the same, nice copy UX, just on a finer granularity.
Anyone have ideas how to test this best? Happy to learn!
The reason will be displayed to describe this comment to others. Learn more.
Just noticed a slight change in UI here: bc the icon takes a bit more space the line itself takes more space and the red marker on the side does not scale with it
Just noticed a slight change in UI here: bc the icon takes a bit more space the line itself takes more space and the red marker on the side does not scale with it
Ah so, this was somewhat on purpose but I forgot to mention it: I added a bit of vertical padding because single-line highlights seemed too narrow, especially with the new button. If you're fine with it, I'll keep the padding but ensure that the red marker scales to the entire highlight block. Once that's done, I'll merge it but we can revisit the styling in a new PR. I got some feedback that we should change the color of the red marker anyway, so we could then tackle it in the same PR :)
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lms24
force-pushed
the
lms/feat-copy-highlighted-code-blocks
branch
from
, thank you!
This PR adds a copy to clipboard button for highlighted line groups within a code block.
Why? In larger code examples, I find the main copy to clipboard button impractical because it copies a lot of code that's already there. So most of the time, it's unusable for me, making me have to highlight and select the appropriate code parts anyway. Since we can highlight the important code parts, this has already gotten much easier. But I think we can go a step further and offer the same, nice copy UX, just on a finer granularity.
Anyone have ideas how to test this best? Happy to learn!
Demo:
Screen.Recording.2025-03-12.at.15.43.44.mov
Update: new copy feedback:
Screen.Recording.2025-03-28.at.12.14.43.mov