Skip to content

Add note about server-side tunneling with JS #13143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 28, 2025

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 27, 2025

DESCRIBE YOUR PR

Based on a suggestion from getsentry/sentry-javascript#15826

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

EXTRA RESOURCES

@AbhiPrasad AbhiPrasad self-assigned this Mar 27, 2025
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 4:14pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2025 4:14pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Mar 27, 2025 4:14pm

Copy link

codecov bot commented Mar 27, 2025

Bundle Report

Changes will decrease total bundle size by 15 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.6MB -9 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 9.43MB -6 bytes (-0.0%) ⬇️

Affected Assets, Files, and Routes:

view changes for bundle: sentry-docs-server-cjs

Assets Changed:

Asset Name Size Change Total Size Change (%)
1729.js -3 bytes 1.58MB -0.0%
../instrumentation.js -3 bytes 910.48kB -0.0%
9523.js -3 bytes 886.53kB -0.0%
view changes for bundle: sentry-docs-client-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
static/chunks/pages/_app-*.js -3 bytes 869.5kB -0.0%
static/chunks/4741-*.js -3 bytes 394.85kB -0.0%
static/OXt61ImAV8Mdb3qJZbYip/_buildManifest.js (New) 578 bytes 578 bytes 100.0% 🚀
static/OXt61ImAV8Mdb3qJZbYip/_ssgManifest.js (New) 77 bytes 77 bytes 100.0% 🚀
static/lUXKHewwwV8owWFWLeH5G/_buildManifest.js (Deleted) -578 bytes 0 bytes -100.0% 🗑️
static/lUXKHewwwV8owWFWLeH5G/_ssgManifest.js (Deleted) -77 bytes 0 bytes -100.0% 🗑️

@WooWan
Copy link

WooWan commented Mar 27, 2025

Looks good to me!

@AbhiPrasad AbhiPrasad merged commit d08d170 into master Mar 28, 2025
11 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-server-side-js-tunnel branch March 28, 2025 23:00
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants