fix: Don't mention Request #1446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to say it's related to `Request` since [the `Request` interface hangs off of the event](https://docs.sentry.io/development/sdk-dev/event-payloads/request/) directly and is not part of the context.
MimiDumpling
approved these changes
Jan 21, 2020
src/collections/_documentation/development/sdk-dev/event-payloads/contexts.md
Outdated
Show resolved
Hide resolved
…ads/contexts.md Co-Authored-By: Tien "Mimi" Nguyen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing to say it's related to
Requestsince theRequestinterface hangs off of the event directly and is not part of the context.Happy to rephrase it, just would like not to say
Requesthere.