Skip to content

hermes landing page #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 3, 2020
Merged

hermes landing page #1515

merged 10 commits into from
Mar 3, 2020

Conversation

bruno-garcia
Copy link
Member

After hermes support was added, a few users had issues.

So far all cases I noticed they were using old SDK or on prem Sentry.

Anything else we need to point out here?

HazAT and others added 2 commits February 27, 2020 17:21
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, one major thing that's wrong here
Everything that lives in /clients/ are the old outdated docs
/platforms/ are the new so this has to go there.

@bruno-garcia
Copy link
Member Author

I have a call, after that I'll move it to the right place.
For now please let's iron out the content. It'll go under /plat

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They have good docs about how to enable it and also to check the min. requirements, so I'd point them out to the official docs.
Something like:

Hermes is disabled by default, if you want to enable it and check its minimum requirements, please have a look at https://reactnative.dev/docs/hermes

@bruno-garcia bruno-garcia marked this pull request as ready for review February 27, 2020 18:08
@bruno-garcia
Copy link
Member Author

@marandaneto @HazAT @Swatinem @MimiDumpling
What's missing to be able to merge this?

Besides I'm sure a snapshot file change I'll need to commit to make CI happy ;)

@MimiDumpling
Copy link
Contributor

@bruno-garcia lemme do a quick spelling and language check. Other than that, it looks pretty good! Thanks for updating the docs 🌻

Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentry-cli version is also important.
Also, some customers that reported problems had customized the way they were building their code. In particular they were uploading the wrong source maps with sentry-cli.
Maybe those steps should be highlighted somewhere?

Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌻 small suggestions. Thanks for updating Docs!

@bruno-garcia
Copy link
Member Author

@Swatinem

Maybe those steps should be highlighted somewhere?

What steps would you suggest?

Copy link
Contributor

@marandaneto marandaneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if more questions come up that would not solve through this doc's, we can make it better later.

@bruno-garcia bruno-garcia requested a review from HazAT March 1, 2020 16:40
@bruno-garcia
Copy link
Member Author

@HazAT I've moved to platforms already

@Swatinem
Copy link
Member

Swatinem commented Mar 2, 2020

What steps would you suggest?

Just to clarify which source maps should be uploaded, since hermes creates two intermediate sourcemaps, which should be avoided. And at least the outdated sentry-cli was using one of the wrong ones.

@bruno-garcia bruno-garcia merged commit 7c16edf into master Mar 3, 2020
@bruno-garcia bruno-garcia deleted the doc/hermes branch March 3, 2020 22:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants