-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
hermes landing page #1515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hermes landing page #1515
Conversation
Co-Authored-By: Manoel Aranda Neto <[email protected]>
Co-Authored-By: Alberto Leal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, one major thing that's wrong here
Everything that lives in /clients/
are the old outdated docs
/platforms/
are the new so this has to go there.
Co-Authored-By: Daniel Griesser <[email protected]>
I have a call, after that I'll move it to the right place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They have good docs about how to enable it and also to check the min. requirements, so I'd point them out to the official docs.
Something like:
Hermes is disabled by default, if you want to enable it and check its minimum requirements, please have a look at https://reactnative.dev/docs/hermes
@marandaneto @HazAT @Swatinem @MimiDumpling Besides I'm sure a snapshot file change I'll need to commit to make CI happy ;) |
@bruno-garcia lemme do a quick spelling and language check. Other than that, it looks pretty good! Thanks for updating the docs 🌻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentry-cli
version is also important.
Also, some customers that reported problems had customized the way they were building their code. In particular they were uploading the wrong source maps with sentry-cli.
Maybe those steps should be highlighted somewhere?
src/collections/_documentation/platforms/react-native/hermes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌻 small suggestions. Thanks for updating Docs!
src/collections/_documentation/platforms/react-native/hermes.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/platforms/react-native/hermes.md
Outdated
Show resolved
Hide resolved
Co-Authored-By: Tien "Mimi" Nguyen <[email protected]>
Co-Authored-By: Tien "Mimi" Nguyen <[email protected]>
Co-Authored-By: Arpad Borsos <[email protected]>
What steps would you suggest? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if more questions come up that would not solve through this doc's, we can make it better later.
@HazAT I've moved to platforms already |
Just to clarify which source maps should be uploaded, since hermes creates two intermediate sourcemaps, which should be avoided. And at least the outdated |
After hermes support was added, a few users had issues.
So far all cases I noticed they were using old SDK or on prem Sentry.
Anything else we need to point out here?