Skip to content

feat: Adding new docs for sentry-cocoa 5.x #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 20, 2020
Merged

feat: Adding new docs for sentry-cocoa 5.x #1551

merged 7 commits into from
Mar 20, 2020

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Mar 16, 2020 •
edited
Loading

screencapture-0-0-0-0-9001-platforms-cocoa-2020-03-17-11_59_22
0 0 0 0_9001_platforms_cocoa_usage__platform=swift(iPad Pro)

@HazAT HazAT self-assigned this Mar 16, 2020
@HazAT HazAT requested a review from fdrabek March 17, 2020 11:03
@HazAT HazAT requested a review from MimiDumpling March 17, 2020 14:33
@HazAT HazAT marked this pull request as ready for review March 17, 2020 14:33
@MimiDumpling MimiDumpling requested a review from PeloWriter March 17, 2020 18:36
PeloWriter
PeloWriter reviewed Mar 17, 2020
View reviewed changes
@HazAT HazAT requested a review from jan-auer March 18, 2020 07:51
@jan-auer jan-auer removed their request for review March 18, 2020 07:53
@HazAT
Copy link
Member Author

HazAT commented Mar 18, 2020

Thanks @PeloWriter for the detailed review :)

@HazAT
Copy link
Member Author

HazAT commented Mar 19, 2020

@fdrabek @PeloWriter @MimiDumpling
Can I merge this :)?

@MimiDumpling
Copy link
Contributor

@fdrabek @PeloWriter @MimiDumpling
Can I merge this :)?

@PeloWriter did the review. I think she should have final approval from the Docs side. :)

@HazAT HazAT merged commit 33df0f3 into master Mar 20, 2020
@HazAT HazAT deleted the cocoa/5.x branch March 20, 2020 09:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PeloWriter PeloWriter PeloWriter left review comments

@marandaneto marandaneto marandaneto approved these changes

@fdrabek fdrabek Awaiting requested review from fdrabek

@MimiDumpling MimiDumpling Awaiting requested review from MimiDumpling

Assignees

@HazAT HazAT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HazAT @MimiDumpling @marandaneto @PeloWriter