Skip to content

docs: Update Rust docs and snippets for upcoming release #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

Swatinem
Copy link
Member

  • Updates and fixes the code snippets for the upcoming Rust SDK release.
  • Removes most of the sub-pages, and rather direct people to docs.rs.

Copy link
Contributor

@MimiDumpling MimiDumpling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny suggested comma. 🌻 Thanks for updating the docs!

@MimiDumpling
Copy link
Contributor

LGTM 👍 I'll leave approval to @jan-auer for the more technical aspects of the doc


if let Some(client) = Hub.current().client() {
if let Some(client) = sentry::Hub::current().client() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd slightly prefer to keep the import.

@Swatinem Swatinem merged commit fc2bff0 into master Jun 26, 2020
@Swatinem Swatinem deleted the docs/update-rust branch June 26, 2020 07:44
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants