Skip to content

doc(pii): Advanced data scrubbing stabilized #1786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2020

Conversation

untitaker
Copy link
Member

This is the absolute minimum amount of changes we need to get out on June 30th.

Copy link
Contributor

@PeloWriter PeloWriter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

sidebar_order: 4
keywords: ["pii", "gdpr", "personally identifiable data", "compliance"]
---

In addition to using [`beforeSend`]({% link _documentation/data-management/sensitive-data.md %}#custom-event-processing-in-the-sdk) in your SDK or our [server-side data scrubbing features]({% link _documentation/data-management/sensitive-data.md %}#server-side-scrubbing) to redact sensitive data, we are currently beta-testing ways to give you more granular control over server-side data scrubbing of your events. Additional functionality includes:
In addition to using [`beforeSend`]({% link _documentation/data-management/sensitive-data.md %}#custom-event-processing-in-the-sdk) in your SDK or our [regular server-side data scrubbing features]({% link _documentation/data-management/sensitive-data.md %}#server-side-scrubbing) to redact sensitive data, Advanced Data Scrubbing is an alternative way to redact sensitive information just before it is saved in Sentry. It allows you to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the {% link...} approach is apparently problematic - might wish to use the markdown format here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, replaced

@@ -40,7 +30,7 @@ Rules generally consist of three parts:
## Methods

- _Remove_: Remove the entire field. We may choose to either set it to `null`, remove it entirely or replace it with an empty string depending on technical constraints.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: serial comma (add a comma after "remove it entirely")

@@ -40,7 +30,7 @@ Rules generally consist of three parts:
## Methods

- _Remove_: Remove the entire field. We may choose to either set it to `null`, remove it entirely or replace it with an empty string depending on technical constraints.
- _Mask_: Replace all characters with `*`. For creditcards this replaces everything but the last 4 digits.
- _Mask_: Replace all characters with `*`.
- _Hash_: Replace the matched substring with a hashed value.
- _Replace_: Replace the matched substring with a constant placeholder value such as `[Filtered]` or `[creditcard]`. Right now this value cannot be configured.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest replacing "Right now" with "Currently" (it's what we're using in other places, so easier to find if we're searching and making changes. But it's not critical.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the entire sentence was incorrect, removed

@untitaker
Copy link
Member Author

thanks @PeloWriter for reviewing early!

@untitaker untitaker requested a review from priscilawebdev June 25, 2020 18:00
Copy link
Member

@priscilawebdev priscilawebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please 👨‍✈️ → 🚢🇮🇹

@untitaker
Copy link
Member Author

GA toggle PR is here: getsentry/sentry#19630

untitaker added a commit to getsentry/sentry that referenced this pull request Jun 30, 2020
@untitaker untitaker merged commit c649c0b into master Jun 30, 2020
@untitaker untitaker deleted the doc/advanced-data-scrubbing-stable branch June 30, 2020 12:30
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants