-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add Vercel Integration Docs #1854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ceorourke Wondering if it makes more sense to have the docs send them directly to |
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
@scefali what do you think about showing both? I'm not sure if users go to the docs first or the integration directory first. |
@ceorourke Hmmm...I think having two sets of instructions would be confusing. My thought is that if they are already in the integration directory, they will end up finding the Vercel integration and going to the marketplace link that we show. However, if they are trying to install it while looking at the docs there's a good chance they wouldn't even have Sentry open. I'm OK with leaving it as is to be consistent with the others if you'd prefer it. |
Also, do not merge until |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌻 Thanks for updating the docs!
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
src/collections/_documentation/workflow/integrations/global-integrations.md
Outdated
Show resolved
Hide resolved
* If you have not already done so, [instrument your code with Sentry]({%- link _documentation/error-reporting/quickstart.md -%}). | ||
* Ensure you have [installed a repository integration]({%- link _documentation/workflow/releases/index.md -%}#install-repo-integration) and added the relevant repository. | ||
* Add the [Sentry Webpack Plugin](https://github.com/getsentry/sentry-webpack-plugin) to your configuration. For NextJS, use `next.config.js`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ceorourke Why is there an extra line here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make them visually separate because the first 3 bullet points address the case where you're brand new to using sentry and sentry-webpack-plugin but have a Vercel project whereas the final one addresses the case where you already have sentry and sentry-webpack-plugin integrated. I was trying to keep it not long winded, but would it be more clear if I added some bold text indicating which situation you may fall into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for that one extra line
add Mimi's suggestions Co-authored-by: Tien "Mimi" Nguyen <[email protected]>
37293e4
to
090c42b
Compare
Add documentation for the Vercel integration.