ref: Bump and document attachment size limits #1913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
force-pushed
the
ref/attachment-size-limits
branch
from
fa1b642 to
e6349e5
Compare
Swatinem
approved these changes
Jul 21, 2020
| The size of Minidumps can vary between a few kilobytes and many megabytes. | ||
| Contributing factors are the number of threads, size of stack space, and the | ||
| number of heap memory regions referenced from the stack. Sentry limits Minidump | ||
| uploads to _100MB_ and drops all larger requests. |
There was a problem hiding this comment.
is it worth mentioning decompressed size here as well?
There was a problem hiding this comment.
100MB is decompressed limit, and it probably makes sense to link to the compressed limit too somehow? (here and in enriching-error-data/attachments/index.mdx)
There was a problem hiding this comment.
Ah, you're right. We should probably mention both limits. Let me update this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size limits for attachments are now at 100MB. Additionally, this PR adds more information on size limits to the Native SDK and Attachments page.
See getsentry/relay#671
See getsentry/develop#90