Skip to content

Mention vue 3 incompatibility #3704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Jun 7, 2021

Prevents users from adding sentry to vue 3 project.

This saves users from going through with the current tutorial if they have vue 3 project.

Relevant issue: getsentry/sentry-javascript#2925

Prevents users from adding sentry to vue 3 project.
@vercel
Copy link

vercel bot commented Jun 7, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sentry/sentry-docs/85tNjrzQi1ZGCrTgwYkQAbeu9R9U
✅ Preview: https://sentry-docs-git-fork-kaovilai-patch-1.sentry.dev

@PeloWriter
Copy link
Contributor

@rhcarvalho - could you please review?

@rhcarvalho rhcarvalho enabled auto-merge (squash) June 9, 2021 14:29
@rhcarvalho rhcarvalho merged commit 993adad into getsentry:master Jun 9, 2021
@connorshea
Copy link

@kaovilai thanks, this just saved me a good bit of time 😅

@kaovilai
Copy link
Contributor Author

@kaovilai thanks, this just saved me a good bit of time 😅

It was pretty hard to find where to contribute to this doc as there was no direct link from where I was on sentry's website to this repo.

I added sentry to Vue 3 a few months ago.. and now recently.. both time forgot about the incompatibility... After some github.com searching came across this repo.

I figured this PR would end my misery.

@rhcarvalho
Copy link
Contributor

@kaovilai thanks for the contribution! We appreciate it ❤️
I've made further changes to make this visible in more places (main Vue docs page, SDK repo and NPM)

Re: hard to find how to contribute to Wizard, thank you very much for the feedback. I've cut a new issue #3717 to make the matter more explicit, I believe we can make the experience better.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants