Skip to content

Dart: Document Scope Deprecations #5145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 20, 2022
Merged

Dart: Document Scope Deprecations #5145

merged 11 commits into from
Jun 20, 2022

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Jun 14, 2022

Document user and attachments deprecations of Scope.

@vercel
Copy link

vercel bot commented Jun 14, 2022

@denrase is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@denrase denrase marked this pull request as ready for review June 14, 2022 11:41
@denrase denrase requested a review from a team as a code owner June 14, 2022 11:41
@vercel
Copy link

vercel bot commented Jun 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 10:12AM (UTC)

marandaneto
marandaneto reviewed Jun 14, 2022
View reviewed changes
marandaneto
marandaneto reviewed Jun 14, 2022
View reviewed changes
@marandaneto marandaneto requested a review from imatwawana June 14, 2022 11:56
@marandaneto
Copy link
Contributor

marandaneto commented Jun 14, 2022 •
edited
Loading

@denrase missing an entry for the changing of the return type, from void to Future<void>.
I'd also add the sync scope config under the docs for Flutter, See Android https://docs.sentry.io/platforms/android/enriching-events/scopes/#scope-synchronization
Or at least adding the option in the common page https://docs.sentry.io/platforms/flutter/configuration/options/#hybrid-sdk-options

imatwawana
imatwawana approved these changes Jun 14, 2022
View reviewed changes
Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a couple wording edits

marandaneto
marandaneto reviewed Jun 14, 2022
View reviewed changes
marandaneto
marandaneto reviewed Jun 14, 2022
View reviewed changes
@denrase denrase requested a review from marandaneto June 15, 2022 09:23
@denrase
Copy link
Collaborator Author

denrase commented Jun 15, 2022 •
edited
Loading

@marandaneto Could we do another vercel deploy to see if the new sync section is created correctly?

marandaneto
marandaneto reviewed Jun 15, 2022
View reviewed changes
@marandaneto marandaneto enabled auto-merge (squash) June 20, 2022 09:56
@marandaneto marandaneto merged commit 710f61b into getsentry:master Jun 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marandaneto marandaneto marandaneto approved these changes

@imatwawana imatwawana imatwawana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denrase @marandaneto @imatwawana