-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Docs for PyMongo integration #5469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* Added guide for PyMongo * Added wizard for PyMongo
Someone is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some edits to more closely align with our style guidelines and fixed a couple typos.
Co-authored-by: Isabel <[email protected]>
Thanks. I've also noticed a few inconsistencies in |
One more thing. Just realised that list of integrations on the right is provided for "frameworks" according to the main python page. Should PyMongo docs instead be placed to Configuration -> Integrations section? Redis and SQLAlchemy are there - but so is Flask which should rather be considered a framework. |
@getsentry/team-web-sdk-backend - You'll need to answer this. |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Well. Still waiting for decision on docs placement but it doesn't matter as long as integration itself is not reviewed. |
sorry @Agalin, we'll try to fit this in soon, too much going on. |
Imo the guides are a good place. (If you are interested: There is currently a discussion going on about maybe changing the location of some parts of the documentation, but because we have a lot of different languages/platforms that work in different ways this can be a longer endeavor: #5669 ) |
I have added a screenshot and moved some parts a bit around in your PR, could you merge this in please: operasoftware#1 @Agalin ? |
Added a few minor comments to that one. Keep in mind I still need to update those docs with results of the discussion here (notably about |
* Added guide for PyMongo * Added wizard for PyMongo
Co-authored-by: Isabel <[email protected]>
db97afc
to
7d868a6
Compare
I have now made the changes @Agalin |
You've merged my latest changes so yeah, it's fine. There is one small discussion left in that pull request. |
So now this PR is ready for release. After the Python SDK was released, I will merge this. |
Docs for getsentry/sentry-python/#1590
TBH I wasn't able to test this change, setting up docs build environment is harder than implementing PyMongo integration in Python SDK. 😓 Python 2 is no longer part of the macOS and I'd rather avoid installing it on my machine while it's required due to ancient
node-gyp
version. Latest node container also fails after installing Python 2.7 on hard to debug C code.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.