Update example to follow HMAC best practice #5753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Python example for the webhook signature comparison to follow best practices. Using `hmac.compare_digest()` mitigates [timing-based attacks](https://en.wikipedia.org/wiki/Timing_attack) on the signature verification. I've also a updated the line to pull the signature header value to use the `.get()` method in order to avoid a `KeyError` exception.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Separating the checks to provide more clarity
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Python example for the webhook signature comparison to follow best practices.
Using
hmac.compare_digest()mitigates timing-based attacks on the signature verification.I've also updated the line to pull the signature header value to use the
.get()method in order to avoid aKeyErrorexception.