-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
ref(issue-alert): add test notifications and preview #5959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a recommendation for further clarification on the alert preview as well as some wording edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay this is great! One more question and once that's clear, this is good to go.
Co-authored-by: Isabel <[email protected]>
Co-authored-by: Isabel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one last tiny wording nitpick, but otherwise this LGTM! Thanks for all the work to refine this.
Co-authored-by: Isabel <[email protected]>
Adds some documentation for notification tests and rule previews.