Skip to content

ref(issue-alert): add test notifications and preview #5959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 16, 2022

Conversation

Zandew
Copy link
Contributor

@Zandew Zandew commented Dec 13, 2022

Adds some documentation for notification tests and rule previews.

@vercel
Copy link

vercel bot commented Dec 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
sentry-docs ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 8:47PM (UTC)

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a recommendation for further clarification on the alert preview as well as some wording edits.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is great! One more question and once that's clear, this is good to go.

Copy link
Contributor

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one last tiny wording nitpick, but otherwise this LGTM! Thanks for all the work to refine this.

@Zandew Zandew merged commit 73233f5 into master Dec 16, 2022
@Zandew Zandew deleted the zandew/issue-alert-updates branch December 16, 2022 17:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants