Clarify offline caching behavior of Flutter SDK #6069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The iOS and Android offline caching functionality behaves slightly differently. This is currently clear in the respective iOS and Android docs: - [iOS](https://docs.sentry.io/platforms/apple/guides/ios/): "Offline caching when a device is unable to connect; we send a report once we receive another event" - [Android](https://docs.sentry.io/platforms/android/): "Offline caching when a device is offline; we send a report once the application is restarted" But, the docs are not clear about how offline caching works in the Flutter SDK, so I've suggested a clarification.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
marandaneto
reviewed
Jan 16, 2023
Comment on lines
14
to
15
| - Android: Offline caching when a device is offline; we send a report once the application is restarted | ||
| - iOS: Offline caching when a device is unable to connect; we send a report once we receive another event |
There was a problem hiding this comment.
Maybe worth that to RN, Capacitor, and on Android/iOS as well.
There was a problem hiding this comment.
Good idea, I'll add those to this PR
There was a problem hiding this comment.
- Added clarification for handling of mobile offline storage to React Native and Cordova ✔️
It looks like Capacitor has solid coverage for how it handles offline storage, so do iOS and Android
marandaneto
approved these changes
Jan 20, 2023
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offline caching functionality for iOS and Android behave differently; reports are retried under slightly different conditions. This is already clear in the respective iOS and Android docs:
However, the Flutter docs are vague about how offline caching works in a way that has confused at least one customer. This change clarifies how offline caching works for Flutter.