Skip to content

feat(replay): Add note about potential Angular performance impact #6267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 10, 2023
Merged

feat(replay): Add note about potential Angular performance impact #6267

merged 3 commits into from
Feb 10, 2023

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 9, 2023 •
edited
Loading

image

@vercel
Copy link

vercel bot commented Feb 9, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 9, 2023 at 10:42PM (UTC)

@billyvg billyvg marked this pull request as ready for review February 9, 2023 15:07
@billyvg billyvg requested a review from a team as a code owner February 9, 2023 15:07
@billyvg
Copy link
Member Author

billyvg commented Feb 9, 2023

Not sure why link isn't working

Lms24
Lms24 reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, not sure if we actually need this, given that we've only received two reports so far?
But I might be missing something/not be up to date, so feel free to merge it if y'all discussed this already.

@billyvg
Copy link
Member Author

billyvg commented Feb 9, 2023

@Lms24 We talked about this briefly in a meeting, this was a potential solution in order to be extra cautious. It's hard for us to determine actual impact since we're relying on 2 layers of feedback.

Lms24
Lms24 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough, thanks for explaining

jas-kas
jas-kas requested changes Feb 9, 2023
View reviewed changes
Copy link
Member

@jas-kas jas-kas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@billyvg Can we only show this on the Session Replay instructions for Angular - https://docs.sentry.io/platforms/javascript/guides/angular/session-replay/

Right now, it shows up on every single instruction for each platform (Ember, Gatsby, etc.) which I think is unnecessary and seems alarming.

Also, the bolding and hyperlinking seems to be broken in the note : (

Screen Shot 2023-02-09 at 3 21 04 PM

lizokm
lizokm approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the link, hopefully it's fix that and the bolding issue... but definitely agree with @jas-kas that we should only have this show up in Angular.

src/platforms/javascript/common/session-replay/index.mdx Outdated
Comment on lines 34 to 37
<Alert level="warning">
We’re investigating possible performance degradation in some **Angular applications**. We recommend testing your application before releasing. Please reach out via [this GitHub ticket](https://github.com/getsentry/sentry-javascript/issues/6946) if you have issues.
</Alert>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Alert level="warning">
We’re investigating possible performance degradation in some **Angular applications**. We recommend testing your application before releasing. Please reach out via [this GitHub ticket](https://github.com/getsentry/sentry-javascript/issues/6946) if you have issues.
</Alert>
<Alert level="warning">
We’re investigating possible performance degradation in some **Angular applications**. We recommend testing your application before releasing. Please reach out via <a class href=“https://github.com/getsentry/sentry-javascript/issues/6946”>this GitHub ticket</a> if you have issues.
</Alert>

Links haven't been working in alerts/notes for some reason. ^^ they do seems to work if we write them this way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like markdown is not supported inside of react components, thanks!

@billyvg billyvg requested a review from jas-kas February 9, 2023 22:25
@billyvg billyvg merged commit d6c1ee8 into master Feb 10, 2023
@billyvg billyvg deleted the feat-add-note-about-angular-performance branch February 10, 2023 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lms24 Lms24 Lms24 approved these changes

@lizokm lizokm lizokm approved these changes

@jas-kas jas-kas jas-kas approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@billyvg @Lms24 @lizokm @jas-kas