-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add docs for loguru
integration
#6617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(Again) mostly copied from `logging` docs
@PerchunPak is attempting to deploy a commit to the Sentry Team on Vercel. A member of the Team first needs to authorize it. |
Thanks for writing docs! I'll wait to see what happens with the SDK PR before we review :) |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Commenting to keep open |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hey @PerchunPak ! Thanks for the docs (and sorry I did not see them earlier). (Because the guides are kind of confusing, because all the pages of the documentation are duplicated for all the guides. I kind of want to go away from the guides and have the integrations documented in the configuration section. And I want to also have a better "index" of our integrations, because we have a lot and do not present them well) Thanks! |
Hey @PerchunPak ! I have changed some things around in the page to make the structure of the page more like the other integrations docs pages. But I am not allowed to push to your branch. Can you please give me access? (there is somewhere a checkbox to allow uptream persons to push) |
Ignore my last comment @PerchunPak . Managed to push to the right branch. |
Hey @shanamatthews , |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Really just one spot where I was confused on one of the code snippets. Thanks @PerchunPak for writing these up and @antonpirker for helping get them in great shape!
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
src/platforms/python/common/configuration/integrations/loguru.mdx
Outdated
Show resolved
Hide resolved
Sorry for such delay, the life happened. |
Hey @PerchunPak ! No worries, life is happening over here also all the time :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now ready, and I will merge when the Loguru integration is released! |
I will look at changes in the evening too |
Oh, well, okay. |
(Again) mostly copied from
logging
docs.My PR about adding
loguru
integration - getsentry/sentry-python#1994.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.