Skip to content

Add docs for loguru integration #6617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 15, 2023
Merged

Add docs for loguru integration #6617

merged 10 commits into from
May 15, 2023

Conversation

PerchunPak
Copy link
Contributor

(Again) mostly copied from logging docs.

My PR about adding loguru integration - getsentry/sentry-python#1994.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

(Again) mostly copied from `logging` docs
@vercel
Copy link

vercel bot commented Apr 8, 2023

@PerchunPak is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@shanamatthews
Copy link
Contributor

Thanks for writing docs! I'll wait to see what happens with the SDK PR before we review :)

@shanamatthews shanamatthews self-assigned this Apr 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@shanamatthews
Copy link
Contributor

Commenting to keep open

@vercel
Copy link

vercel bot commented May 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2023 9:23pm

@PerchunPak
Copy link
Contributor Author

I do not really understand, how to add an image here?

image

@antonpirker
Copy link
Member

Hey @PerchunPak !

Thanks for the docs (and sorry I did not see them earlier).
Could you please move the docs from the "guides" folder to this directory: https://github.com/getsentry/sentry-docs/blob/master/src/platforms/python/common/configuration/integrations/redis.mdx#L19

(Because the guides are kind of confusing, because all the pages of the documentation are duplicated for all the guides. I kind of want to go away from the guides and have the integrations documented in the configuration section. And I want to also have a better "index" of our integrations, because we have a lot and do not present them well)

Thanks!

@antonpirker
Copy link
Member

Hey @PerchunPak !

I have changed some things around in the page to make the structure of the page more like the other integrations docs pages.

But I am not allowed to push to your branch. Can you please give me access? (there is somewhere a checkbox to allow uptream persons to push)

@antonpirker
Copy link
Member

Ignore my last comment @PerchunPak . Managed to push to the right branch.

@antonpirker
Copy link
Member

Hey @shanamatthews ,
could you please have a look if this is proper English?

Copy link
Contributor

@shanamatthews shanamatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Really just one spot where I was confused on one of the code snippets. Thanks @PerchunPak for writing these up and @antonpirker for helping get them in great shape!

@PerchunPak
Copy link
Contributor Author

Sorry for such delay, the life happened.

@antonpirker
Copy link
Member

antonpirker commented May 15, 2023

Hey @PerchunPak ! No worries, life is happening over here also all the time :-)

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@antonpirker
Copy link
Member

This is now ready, and I will merge when the Loguru integration is released!

@PerchunPak
Copy link
Contributor Author

I will look at changes in the evening too

@antonpirker antonpirker merged commit 19059bd into getsentry:master May 15, 2023
@PerchunPak PerchunPak deleted the loguru-integration branch May 15, 2023 13:23
@PerchunPak
Copy link
Contributor Author

Oh, well, okay.

@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants