Skip to content

Fix overflowing table on searchable properties screen #7319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 10, 2023

Conversation

stephanie-anderson
Copy link
Contributor

@stephanie-anderson stephanie-anderson commented Jul 5, 2023

These modifications have partially been done with scripting. The table contents have not been manually transferred, but through a script. Thereby I don't expect any copy/paste errors to appear in the content.

1) fixes #4824

  • fix searchable properties (overflowing table)
  • replace table with a list
  • sort all keys/tokens alphabetically
  • adapt description text above table/list
  • make each properties linkable with an anchor (#property)

Other tables that caused overflowing issues before have already been reworked to only have 4 or less columns and thereby don't overflow anymore:

2) fixes #7023

  • filtering tables is still not possible, but the underlying issue of struggling to find searchable properties for a given type (event, issue, replay, release) has been fixed with separated pages (in addition to the overall list of properties).

- replace table with a list
- adapt description text above table/list
- make each properties linkable with an anchor (#property)
@vercel
Copy link

vercel bot commented Jul 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2023 10:57am

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@vivianyentran vivianyentran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the table!

@stephanie-anderson stephanie-anderson merged commit 9f6c783 into master Jul 10, 2023
@stephanie-anderson stephanie-anderson deleted the replace-overflowing-table-with-list branch July 10, 2023 12:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering Tables table doesn't resize properly
3 participants