-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Fix overflowing table on searchable properties screen #7319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
stephanie-anderson
merged 16 commits into
master
from
replace-overflowing-table-with-list
Jul 10, 2023
Merged
Fix overflowing table on searchable properties screen #7319
stephanie-anderson
merged 16 commits into
master
from
replace-overflowing-table-with-list
Jul 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- replace table with a list - adapt description text above table/list - make each properties linkable with an anchor (#property)
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ties table by type (event, issue, replay, release) and instead provide a dedicated list / page for each
bruno-garcia
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/docs/product/sentry-basics/search/searchable-properties/events.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/sentry-basics/search/searchable-properties/issues.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/sentry-basics/search/searchable-properties/releases.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/sentry-basics/search/searchable-properties/session-replay.mdx
Outdated
Show resolved
Hide resolved
src/docs/product/sentry-basics/search/searchable-properties/index.mdx
Outdated
Show resolved
Hide resolved
…leases.mdx Commit suggestion from @vivianyentran Co-authored-by: vivianyentran <[email protected]>
…sues.mdx Commit suggestion from @vivianyentran Co-authored-by: vivianyentran <[email protected]>
…ents.mdx Commit suggestion from @vivianyentran Co-authored-by: vivianyentran <[email protected]>
vivianyentran
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the table!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These modifications have partially been done with scripting. The table contents have not been manually transferred, but through a script. Thereby I don't expect any copy/paste errors to appear in the content.
1) fixes #4824
Other tables that caused overflowing issues before have already been reworked to only have 4 or less columns and thereby don't overflow anymore:
2) fixes #7023