Skip to content

fix(js): Remove span status enum usage in js docs #7790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

AbhiPrasad
Copy link
Member

Fixes #7789

SpanStatus enum is deprecated, so let's replace with normal strings.

@AbhiPrasad AbhiPrasad requested a review from a team September 12, 2023 21:02
@AbhiPrasad AbhiPrasad requested a review from a team as a code owner September 12, 2023 21:02
@AbhiPrasad AbhiPrasad requested review from stephanie-anderson and ale-cota and removed request for a team September 12, 2023 21:02
@vercel
Copy link

vercel bot commented Sep 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 12, 2023 9:13pm

@AbhiPrasad AbhiPrasad merged commit 90b8668 into master Sep 13, 2023
@AbhiPrasad AbhiPrasad deleted the abhi-js-span-status branch September 13, 2023 04:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Documentation for Custom Instrumentation in JavaScript SDK
2 participants