Skip to content

Add wrapRemixHandleError instructions #8681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 14, 2023
Merged

Conversation

onurtemizkan
Copy link
Collaborator

Ref: getsentry/sentry-javascript#9725

Updated handleError instructions to reflect the new feature.

Also updated external links from Remix v1 documentation to v2.

Copy link

vercel bot commented Dec 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 5:52pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
sentry-docs-next ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 5:52pm

Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few language tweaks, but otherwise this looks great!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) December 14, 2023 17:39
@AbhiPrasad AbhiPrasad merged commit a9c43ad into master Dec 14, 2023
@AbhiPrasad AbhiPrasad deleted the onur/remix-wrap-handle-error branch December 14, 2023 17:50
@jgentes
Copy link

jgentes commented Dec 30, 2023

I can file a bug for this, but using v7.91.0 of @sentry/remix generates: No matching export in "node_modules/@sentry/remix/esm/index.client.js" for import "wrapRemixHandleError". Surprisingly v7.87.0 also has the same error?

My entry.server.tsx file has:

import { init as SentryInit, wrapRemixHandleError } from '@sentry/remix'
import { renderHeadToString } from 'remix-island'
import { Head } from './root'

import { renderToReadableStream } from 'react-dom/server'

SentryInit({
	dsn: 'https://6ea...',
	tracesSampleRate: 0.1
})

export const handleError = wrapRemixHandleError

@jgentes
Copy link

jgentes commented Dec 30, 2023

I got it, the fix is to use export const handleError = Sentry.wrapRemixHandleError instead.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants