Skip to content

feat(js): Move some configuration pages to "Best Practices" #9571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 28, 2024

Description of changes

Some pages in "Configuration" do not really contain configuration examples, but offer more of a "guideline". Users might search for usage examples for "Micro Frontends" or "Browser Extensions". Therefore, "Best Practices" are created. Talked with @HazAT and @mydea about this.

@s1gr1d s1gr1d self-assigned this Mar 28, 2024
Copy link

vercel bot commented Mar 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 2:30pm

@s1gr1d s1gr1d requested review from HazAT and mydea March 28, 2024 09:58
Copy link

codecov bot commented Mar 28, 2024

Bundle Report

Changes will increase total bundle size by 1.14kB ⬆️

Bundle name Size Change
sentry-docs-server 6.11MB 702 bytes ⬆️
sentry-docs-edge-server 618.5kB 445 bytes ⬆️
sentry-docs-client 5.52MB 6 bytes ⬇️

@HazAT
Copy link
Member

HazAT commented Apr 3, 2024

These pages shouldn't show up on the right, instead there should be a new menu item on the left called "Guides" and be sub items there
image

@s1gr1d s1gr1d force-pushed the sig-create-guides branch from 58c98d0 to 827c62f Compare April 4, 2024 11:03
@s1gr1d s1gr1d marked this pull request as ready for review April 4, 2024 11:03
@s1gr1d s1gr1d requested a review from a team as a code owner April 4, 2024 11:03
Copy link
Contributor

@stephanie-anderson stephanie-anderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that looks really good!

@s1gr1d s1gr1d changed the title feat(js): Move some configuration pages to guides feat(js): Move some configuration pages to "Best Practices" Apr 4, 2024
Copy link
Member

@HazAT HazAT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@s1gr1d s1gr1d merged commit d89826a into master Apr 5, 2024
@s1gr1d s1gr1d deleted the sig-create-guides branch April 5, 2024 12:49
s1gr1d added a commit to getsentry/sentry-javascript that referenced this pull request Apr 9, 2024
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants