fix(core): Avoid console output and telemetry init when plugins are disabled #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.4.0 | 3.5.0 | ## [v3.5.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#350) - feat(core): Add hook to customize source map file resolution ([#732](getsentry/sentry-javascript-bundler-plugins#732)) - fix(core): Avoid console output and telemetry init when plugins are disabled ([#741](getsentry/sentry-javascript-bundler-plugins#741)) Work in this release was contributed by [@thecodewarrior](https://github.com/thecodewarrior). Thank you for your contribution!
renovate bot
added a commit
to andrei-picus-tink/auto-renovate
that referenced
this pull request
May 24, 2025
| datasource | package | from | to | | ---------- | ------------------- | ----- | ----- | | npm | @sentry/vite-plugin | 3.4.0 | 3.5.0 | ## [v3.5.0](https://github.com/getsentry/sentry-javascript-bundler-plugins/blob/HEAD/CHANGELOG.md#350) - feat(core): Add hook to customize source map file resolution ([#732](getsentry/sentry-javascript-bundler-plugins#732)) - fix(core): Avoid console output and telemetry init when plugins are disabled ([#741](getsentry/sentry-javascript-bundler-plugins#741)) Work in this release was contributed by [@thecodewarrior](https://github.com/thecodewarrior). Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #714, we extracted a lot of the plugin pre-initialization logic into the
createSentryBuildPluginManagerfunction. Only after this manager was created, we'd check for thedisabledoption. However, within the plugin manager creation function, we'd already do validation on passed options, as well as initialize the Sentry SDK. Which both previously only happened after we checked for disabled (h/t @s1gr1d and @Jimmy89 for finding this).This PR ensures we early-return within the
createSentryBuildPluginManagerfunction, so that we return a manager that no-ops in some methods. Not the prettiest solution in the world but unfortunately we have to normalize the user options first and merge them withprocess.envand an optional.envfile, before we can reliably check fordisabled. In the future, we could also returnundefinedincreateSentryBuildPluginManagerin case of the plugin being disabled but this would be a breaking change and also somewhat inconvenient.Additionally, I refactored some of the return types to ensure we don't accidentally introduce breaking changes.
fixes #740