Skip to content

feat(express): Add express app example #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 9, 2024

No description provided.

@s1gr1d s1gr1d self-assigned this Apr 9, 2024
@s1gr1d s1gr1d requested review from mydea, lforst and Lms24 April 9, 2024 14:45
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally fine to start with, LGTM! Do we already have a concrete list of scenarios to test our apps against?

@s1gr1d
Copy link
Member Author

s1gr1d commented Apr 9, 2024

No, not yet. I am just adding a baseline right now by using the code from the e2e tests: https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/e2e-tests/test-applications/node-express-app

@s1gr1d s1gr1d merged commit b3fc0ac into v7 Apr 9, 2024
@s1gr1d s1gr1d deleted the sig-add-express-app branch April 9, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants