fix(node): Remove circular dependency between backend and parser (#3633)

When running madge on `@sentry/node`:

$ madge --circular src/index.ts
Processed 10 files (698ms) (8 warnings)

✖ Found 1 circular dependency!

1) backend.ts > parsers.ts

To remove the circular relationship between backend and parsers,
we extract the NodeOptions type into a separate types.ts file.

Author: AbhiPrasad

packages/eslint-config-sdk/package.json

@@ -34,8 +34,7 @@
   },
   "devDependencies": {
     "eslint": "7.27.0",
-    "typescript": "3.7.5",
-    "madge": "4.0.2"
+    "typescript": "3.7.5"
   },
   "scripts": {
     "link:yarn": "yarn link",

packages/node/src/backend.ts

@@ -1,5 +1,5 @@
 import { BaseBackend, getCurrentHub } from '@sentry/core';
-import { Event, EventHint, Mechanism, Options, Severity, Transport, TransportOptions } from '@sentry/types';
+import { Event, EventHint, Mechanism, Severity, Transport, TransportOptions } from '@sentry/types';
 import {
   addExceptionMechanism,
   addExceptionTypeValue,
@@ -13,33 +13,7 @@ import {
 
 import { extractStackFromError, parseError, parseStack, prepareFramesForEvent } from './parsers';
 import { HTTPSTransport, HTTPTransport } from './transports';
-
-/**
- * Configuration options for the Sentry Node SDK.
- * @see NodeClient for more information.
- */
-export interface NodeOptions extends Options {
-  /** Sets an optional server name (device name) */
-  serverName?: string;
-
-  /** Maximum time in milliseconds to wait to drain the request queue, before the process is allowed to exit. */
-  shutdownTimeout?: number;
-
-  /** Set a HTTP proxy that should be used for outbound requests. */
-  httpProxy?: string;
-
-  /** Set a HTTPS proxy that should be used for outbound requests. */
-  httpsProxy?: string;
-
-  /** HTTPS proxy certificates path */
-  caCerts?: string;
-
-  /** Sets the number of context lines for each frame when loading a file. */
-  frameContextLines?: number;
-
-  /** Callback that is executed when a fatal global error occurs. */
-  onFatalError?(error: Error): void;
-}
+import { NodeOptions } from './types';
 
 /**
  * The Sentry Node SDK Backend.

packages/node/src/client.ts

@@ -3,7 +3,8 @@ import { SessionFlusher } from '@sentry/hub';
 import { Event, EventHint, RequestSessionStatus } from '@sentry/types';
 import { logger } from '@sentry/utils';
 
-import { NodeBackend, NodeOptions } from './backend';
+import { NodeBackend } from './backend';
+import { NodeOptions } from './types';
 
 /**
  * The Sentry Node SDK Client.

packages/node/src/index.ts

@@ -38,7 +38,8 @@ export {
   withScope,
 } from '@sentry/core';
 
-export { NodeBackend, NodeOptions } from './backend';
+export { NodeOptions } from './types';
+export { NodeBackend } from './backend';
 export { NodeClient } from './client';
 export { defaultIntegrations, init, lastEventId, flush, close, getSentryRelease } from './sdk';
 export { deepReadDirSync } from './utils';

packages/node/src/parsers.ts

@@ -3,8 +3,8 @@ import { addContextToFrame, basename, dirname, SyncPromise } from '@sentry/utils
 import { readFile } from 'fs';
 import { LRUMap } from 'lru_map';
 
-import { NodeOptions } from './backend';
 import * as stacktrace from './stacktrace';
+import { NodeOptions } from './types';
 
 const DEFAULT_LINES_OF_CONTEXT: number = 7;
 const FILE_CONTENT_CACHE = new LRUMap<string, string | null>(100);

packages/node/src/sdk.ts

@@ -4,9 +4,9 @@ import { SessionStatus } from '@sentry/types';
 import { getGlobalObject } from '@sentry/utils';
 import * as domain from 'domain';
 
-import { NodeOptions } from './backend';
 import { NodeClient } from './client';
 import { Console, Http, LinkedErrors, OnUncaughtException, OnUnhandledRejection } from './integrations';
+import { NodeOptions } from './types';
 
 export const defaultIntegrations = [
   // Common

packages/node/src/types.ts

@@ -0,0 +1,28 @@
+import { Options } from '@sentry/types';
+
+/**
+ * Configuration options for the Sentry Node SDK.
+ * @see NodeClient for more information.
+ */
+export interface NodeOptions extends Options {
+  /** Sets an optional server name (device name) */
+  serverName?: string;
+
+  /** Maximum time in milliseconds to wait to drain the request queue, before the process is allowed to exit. */
+  shutdownTimeout?: number;
+
+  /** Set a HTTP proxy that should be used for outbound requests. */
+  httpProxy?: string;
+
+  /** Set a HTTPS proxy that should be used for outbound requests. */
+  httpsProxy?: string;
+
+  /** HTTPS proxy certificates path */
+  caCerts?: string;
+
+  /** Sets the number of context lines for each frame when loading a file. */
+  frameContextLines?: number;
+
+  /** Callback that is executed when a fatal global error occurs. */
+  onFatalError?(error: Error): void;
+}