fix(node): Remove circular dependency between backend and parser #3633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
force-pushed
the
abhi/fix-circular-dep
branch
from
f682079 to
ee593c9
Compare
size-limit report
|
AbhiPrasad
force-pushed
the
abhi/fix-circular-dep
branch
from
a0adb59 to
43b7e8d
Compare
kamilogorek
reviewed
Jun 2, 2021
AbhiPrasad
force-pushed
the
abhi/circular-dep
branch
from
3711aea to
5f1eb50
Compare
2 tasks
AbhiPrasad
force-pushed
the
abhi/circular-dep
branch
from
5f1eb50 to
a29510c
Compare
Madge (https://www.npmjs.com/package/madge) is a library that can traverse module dependency trees to check for circular dependencies. We can leverage it using `madge --circular /path/to/index.ts` to make sure that our packages don't contain circular deps. On average madge takes around 2-3 sec, so we are not sacrificing a ton of CI time.
Madge (https://www.npmjs.com/package/madge) is a library that can traverse module dependency trees to check for circular dependencies. We can leverage it using `madge --circular /path/to/index.ts` to make sure that our packages don't contain circular deps. On average madge takes around 2-3 sec, so we are not sacrificing a ton of CI time.
When running madge on `@sentry/node`: $ madge --circular src/index.ts Processed 10 files (698ms) (8 warnings) ✖ Found 1 circular dependency! 1) backend.ts > parsers.ts To remove the circular relationship between backend and parsers, we extract the NodeOptions type into a separate types.ts file.
AbhiPrasad
force-pushed
the
abhi/fix-circular-dep
branch
from
43b7e8d to
765acc1
Compare
AbhiPrasad
added a commit
that referenced
this pull request
Jun 2, 2021
When running madge on @sentry/node: $ madge --circular src/index.ts Processed 10 files (698ms) (8 warnings) ✖ Found 1 circular dependency! 1) backend.ts > parsers.ts To remove the circular relationship between backend and parsers, we extract the NodeOptions type into a separate types.ts file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #3631
I am splitting up my changes so that each package bump is reviewed separately. This to to encourage ease of review + split up the changes that could be quite big.
When running madge on
@sentry/node:To remove the circular relationship between backend and parsers,
we extract the NodeOptions type into a separate types.ts file.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).