Skip to content

Commit 2f5c999

Browse files
authored
ci: Run e2e tests for dependabot PRs (#11746)
Let's see if that works now 🤞
1 parent e955925 commit 2f5c999

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

.github/workflows/build.yml

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -942,12 +942,10 @@ jobs:
942942
# We want to run this if:
943943
# - The build job was successful, not skipped
944944
# - AND if the profiling node bindings were either successful or skipped
945-
# AND if this is not a PR from a fork or dependabot
946945
if: |
947946
always() && needs.job_build.result == 'success' &&
948947
(needs.job_compile_bindings_profiling_node.result == 'success' || needs.job_compile_bindings_profiling_node.result == 'skipped') &&
949-
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
950-
github.actor != 'dependabot[bot]'
948+
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
951949
needs: [job_get_metadata, job_build, job_compile_bindings_profiling_node]
952950
runs-on: ubuntu-20.04-large-js
953951
timeout-minutes: 15
@@ -1005,13 +1003,11 @@ jobs:
10051003
job_e2e_tests:
10061004
name: E2E ${{ matrix.label || matrix.test-application }} Test
10071005
# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
1008-
# Dependabot PRs sadly also don't have access to secrets, so we skip them as well
10091006
# We need to add the `always()` check here because the previous step has this as well :(
10101007
# See: https://github.com/actions/runner/issues/2205
10111008
if:
10121009
always() && needs.job_e2e_prepare.result == 'success' &&
1013-
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
1014-
github.actor != 'dependabot[bot]'
1010+
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository)
10151011
needs: [job_get_metadata, job_build, job_e2e_prepare]
10161012
runs-on: ubuntu-20.04
10171013
timeout-minutes: 10
@@ -1141,14 +1137,14 @@ jobs:
11411137
job_profiling_e2e_tests:
11421138
name: E2E ${{ matrix.label || matrix.test-application }} Test
11431139
# We only run E2E tests for non-fork PRs because the E2E tests require secrets to work and they can't be accessed from forks
1144-
# Dependabot PRs sadly also don't have access to secrets, so we skip them as well
1140+
# Dependabot specifically also has access to secrets
11451141
# We need to add the `always()` check here because the previous step has this as well :(
11461142
# See: https://github.com/actions/runner/issues/2205
11471143
if:
11481144
# Only run profiling e2e tests if profiling node bindings have changed
11491145
always() && needs.job_e2e_prepare.result == 'success' &&
11501146
(github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) &&
1151-
github.actor != 'dependabot[bot]' && (
1147+
(
11521148
(needs.job_get_metadata.outputs.changed_profiling_node_bindings == 'true') ||
11531149
(needs.job_get_metadata.outputs.is_release == 'true') ||
11541150
(github.event_name != 'pull_request')

0 commit comments

Comments
 (0)