ci: Run e2e tests for dependabot PRs #11746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
reviewed
Apr 23, 2024
| # We need to add the `always()` check here because the previous step has this as well :( | ||
| # See: https://github.com/actions/runner/issues/2205 | ||
| if: | ||
| # Only run profiling e2e tests if profiling node bindings have changed | ||
| always() && needs.job_e2e_prepare.result == 'success' && | ||
| (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository) && | ||
| github.actor != 'dependabot[bot]' && ( |
There was a problem hiding this comment.
We have a bunch more places with this check I think!
There was a problem hiding this comment.
oops, you are right, totally missed that. Updated in all places now, hopefully!
lforst
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's see if that works now 🤞