ref: Remove assign util in favor of Object.assign

Author: kamilogorek

packages/core/src/dsn.ts

@@ -1,7 +1,6 @@
 import { DsnComponents, DsnLike, DsnProtocol } from '@sentry/types';
 import { SentryError } from '@sentry/utils/error';
 import { isNaN } from '@sentry/utils/is';
-import { assign } from '@sentry/utils/object';
 
 /** Regular expression used to parse a Dsn. */
 const DSN_REGEX = /^(?:(\w+):)\/\/(?:(\w+)(?::(\w+))?@)([\w\.-]+)(?::(\d+))?\/(.+)/;
@@ -67,7 +66,7 @@ export class Dsn implements DsnComponents {
       path = split.slice(0, -1).join('/');
       projectId = split.pop() as string;
     }
-    assign(this, { host, pass, path, projectId, port, protocol, user });
+    Object.assign(this, { host, pass, path, projectId, port, protocol, user });
   }
 
   /** Maps Dsn components into this instance. */

packages/core/src/integrations/extraerrordata.ts

@@ -4,7 +4,6 @@ import { isError, isPlainObject } from '@sentry/utils/is';
 import { logger } from '@sentry/utils/logger';
 import { safeNormalize } from '@sentry/utils/object';
 
-
 /** Patch toString calls to return proper name for wrapped functions */
 export class ExtraErrorData implements Integration {
   /**
@@ -44,13 +43,15 @@ export class ExtraErrorData implements Integration {
       let extra = {
         ...event.extra,
       };
+
       const normalizedErrorData = safeNormalize(errorData);
-      if (!isString(normalizedErrorData)) {
+      if (isPlainObject(normalizedErrorData)) {
         extra = {
           ...event.extra,
           ...normalizedErrorData,
         };
       }
+
       return {
         ...event,
         extra,

packages/hub/src/scope.ts

@@ -1,7 +1,7 @@
 import { Breadcrumb, Event, EventHint, EventProcessor, Scope as ScopeInterface, Severity, User } from '@sentry/types';
 import { isFunction, isThenable } from '@sentry/utils/is';
 import { getGlobalObject } from '@sentry/utils/misc';
-import { assign, safeNormalize } from '@sentry/utils/object';
+import { safesafeNormalize } from '@sentry/utils/object';
 import { SyncPromise } from '@sentry/utils/syncpromise';
 
 /**
@@ -123,12 +123,12 @@ export class Scope implements ScopeInterface {
    */
   public static clone(scope?: Scope): Scope {
     const newScope = new Scope();
-    assign(newScope, scope, {
+    Object.assign(newScope, scope, {
       scopeListeners: [],
     });
     if (scope) {
-      newScope.extra = assign(scope.extra);
-      newScope.tags = assign(scope.tags) as any;
+      newScope.extra = { ...scope.extra };
+      newScope.tags = { ...scope.tags };
       newScope.breadcrumbs = [...scope.breadcrumbs];
       newScope.eventProcessors = [...scope.eventProcessors];
     }

packages/utils/src/object.ts

@@ -193,36 +193,6 @@ export function serializeKeysToEventMessage(keys: string[], maxLength: number =
   return '';
 }
 
-// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#Polyfill
-/** JSDoc */
-export function assign(target: any, ...args: any[]): object {
-  if (target === null || target === undefined) {
-    throw new TypeError('Cannot convert undefined or null to object');
-  }
-
-  const to = Object(target) as {
-    [key: string]: any;
-  };
-
-  // tslint:disable-next-line:prefer-for-of
-  for (let i = 0; i < args.length; i++) {
-    const source = args[i];
-    if (source !== null) {
-      for (const nextKey in source as {
-        [key: string]: any;
-      }) {
-        if (Object.prototype.hasOwnProperty.call(source, nextKey)) {
-          to[nextKey] = (source as {
-            [key: string]: any;
-          })[nextKey];
-        }
-      }
-    }
-  }
-
-  return to;
-}
-
 /**
  * Transforms Error object into an object literal with all it's attributes
  * attached to it.