build(replay): Streamline tsconfig & jest config (#6399)

* Move some tsconfig stuff we need for tests only to tsconfig.test.json
* Add some more common folders to vscode search.exclude
* Stop using @test imports in replay
* Make replay tests non-verbose

Author: mydea

.vscode/settings.json

@@ -10,7 +10,9 @@
   "search.exclude": {
     "**/node_modules/": true,
     "**/build/": true,
-    "**/dist/": true
+    "**/dist/": true,
+    "**/coverage/": true,
+    "**/yarn-error.log": true
   },
   "typescript.tsdk": "./node_modules/typescript/lib",
   "[json]": {

packages/replay/.eslintrc.js

@@ -60,8 +60,6 @@ module.exports = {
       files: ['test/**/*.ts'],
 
       rules: {
-        // TODO: decide if we want to keep our '@test' import paths
-        'import/no-unresolved': 'off',
         // most of these errors come from `new Promise(process.nextTick)`
         '@typescript-eslint/unbound-method': 'off',
         // TODO: decide if we want to enable this again after the migration

packages/replay/jest.config.ts

@@ -1,22 +1,15 @@
 import type { Config } from '@jest/types';
-import { pathsToModuleNameMapper } from 'ts-jest';
 import { jsWithTs as jsWithTsPreset } from 'ts-jest/presets';
 
-import { compilerOptions } from './tsconfig.test.json';
-
 export default async (): Promise<Config.InitialOptions> => {
   return {
     ...jsWithTsPreset,
-    verbose: true,
     globals: {
       'ts-jest': {
         tsconfig: '<rootDir>/tsconfig.test.json',
       },
       __DEBUG_BUILD__: true,
     },
-    moduleNameMapper: pathsToModuleNameMapper(compilerOptions.paths, {
-      prefix: '<rootDir>/',
-    }),
     setupFilesAfterEnv: ['./jest.setup.ts'],
     testEnvironment: 'jsdom',
     testMatch: ['<rootDir>/test/**/*(*.)@(spec|test).ts'],

packages/replay/test/mocks/index.ts

@@ -1,9 +1,9 @@
 import { getCurrentHub } from '@sentry/core';
-import { BASE_TIMESTAMP, RecordMock } from '@test';
-import { DomHandler, MockTransportSend } from '@test/types';
-import { Replay } from 'src';
 
 import { ReplayConfiguration } from '../../src/types';
+import { Replay } from './../../src';
+import { BASE_TIMESTAMP, RecordMock } from './../index';
+import { DomHandler, MockTransportSend } from './../types';
 
 export async function resetSdkMock(options?: ReplayConfiguration): Promise<{
   domHandler: DomHandler;

packages/replay/test/unit/coreHandlers/handleFetch.test.ts

@@ -1,6 +1,5 @@
-import { mockSdk } from '@test';
-
 import { handleFetch } from '../../../src/coreHandlers/handleFetch';
+import { mockSdk } from './../../index';
 
 jest.unmock('@sentry/browser');
 

packages/replay/test/unit/coreHandlers/handleScope-unit.test.ts

@@ -1,7 +1,7 @@
 import { getCurrentHub } from '@sentry/core';
-import { mockSdk } from '@test';
 
 import * as HandleScope from '../../../src/coreHandlers/handleScope';
+import { mockSdk } from './../../index';
 
 let mockHandleScope: jest.MockedFunction<typeof HandleScope.handleScope>;
 

packages/replay/test/unit/createPerformanceEntry.test.ts

@@ -1,6 +1,5 @@
-import { mockSdk } from '@test';
-
 import { createPerformanceEntries } from '../../src/createPerformanceEntry';
+import { mockSdk } from './../index';
 
 jest.unmock('@sentry/browser');
 

packages/replay/test/unit/eventBuffer.test.ts

@@ -1,9 +1,9 @@
 import 'jsdom-worker';
 
-import { BASE_TIMESTAMP } from '@test';
 import pako from 'pako';
 
 import { createEventBuffer, EventBufferCompressionWorker } from './../../src/eventBuffer';
+import { BASE_TIMESTAMP } from './../index';
 
 const TEST_EVENT = { data: {}, timestamp: BASE_TIMESTAMP, type: 3 };
 

packages/replay/test/unit/flush.test.ts

@@ -1,10 +1,10 @@
 import * as SentryUtils from '@sentry/utils';
-import { BASE_TIMESTAMP, mockRrweb, mockSdk } from '@test';
 
 import { SESSION_IDLE_DURATION, WINDOW } from '../../src/constants';
 import { Replay } from './../../src';
 import { createPerformanceEntries } from './../../src/createPerformanceEntry';
 import { useFakeTimers } from './../../test/utils/use-fake-timers';
+import { BASE_TIMESTAMP, mockRrweb, mockSdk } from './../index';
 
 useFakeTimers();
 

packages/replay/test/unit/index-errorSampleRate.test.ts

@@ -1,13 +1,13 @@
 jest.unmock('@sentry/browser');
 
 import { captureException } from '@sentry/browser';
-import { BASE_TIMESTAMP, RecordMock } from '@test';
-import { PerformanceEntryResource } from '@test/fixtures/performanceEntry/resource';
-import { resetSdkMock } from '@test/mocks';
-import { DomHandler, MockTransportSend } from '@test/types';
 
 import { REPLAY_SESSION_KEY, VISIBILITY_CHANGE_TIMEOUT, WINDOW } from '../../src/constants';
 import { Replay } from './../../src';
+import { PerformanceEntryResource } from './../fixtures/performanceEntry/resource';
+import { BASE_TIMESTAMP, RecordMock } from './../index';
+import { resetSdkMock } from './../mocks';
+import { DomHandler, MockTransportSend } from './../types';
 import { useFakeTimers } from './../utils/use-fake-timers';
 
 useFakeTimers();

packages/replay/test/unit/index-handleGlobalEvent.test.ts

@@ -1,10 +1,10 @@
 import { getCurrentHub } from '@sentry/core';
-import { Error } from '@test/fixtures/error';
-import { Transaction } from '@test/fixtures/transaction';
-import { resetSdkMock } from '@test/mocks';
 
 import { REPLAY_EVENT_NAME } from '../../src/constants';
 import { Replay } from './../../src';
+import { Error } from './../fixtures/error';
+import { Transaction } from './../fixtures/transaction';
+import { resetSdkMock } from './../mocks';
 import { useFakeTimers } from './../utils/use-fake-timers';
 
 useFakeTimers();

packages/replay/test/unit/index-integrationSettings.test.ts

@@ -1,6 +1,5 @@
-import { mockSdk } from '@test';
-
 import { Replay } from '../../src';
+import { mockSdk } from './../index';
 
 let replay: Replay;
 

packages/replay/test/unit/index-noSticky.test.ts

@@ -1,10 +1,10 @@
 import { getCurrentHub } from '@sentry/core';
 import { Transport } from '@sentry/types';
 import * as SentryUtils from '@sentry/utils';
-import { BASE_TIMESTAMP, mockRrweb, mockSdk } from '@test';
 
 import { SESSION_IDLE_DURATION, VISIBILITY_CHANGE_TIMEOUT } from '../../src/constants';
 import { Replay } from './../../src';
+import { BASE_TIMESTAMP, mockRrweb, mockSdk } from './../index';
 import { useFakeTimers } from './../utils/use-fake-timers';
 
 useFakeTimers();

packages/replay/test/unit/index-sampling.test.ts

@@ -1,8 +1,7 @@
 jest.unmock('@sentry/browser');
 
 // mock functions need to be imported first
-import { mockRrweb, mockSdk } from '@test';
-
+import { mockRrweb, mockSdk } from './../index';
 import { useFakeTimers } from './../utils/use-fake-timers';
 
 useFakeTimers();

packages/replay/test/unit/index.test.ts

@@ -1,16 +1,16 @@
 jest.mock('./../../src/util/isInternal', () => ({
   isInternal: jest.fn(() => true),
 }));
-import { BASE_TIMESTAMP, RecordMock } from '@test';
-import { PerformanceEntryResource } from '@test/fixtures/performanceEntry/resource';
-import { resetSdkMock } from '@test/mocks';
-import { DomHandler, MockTransportSend } from '@test/types';
 import { EventType } from 'rrweb';
 
 import { Replay } from '../../src';
 import { MAX_SESSION_LIFE, REPLAY_SESSION_KEY, VISIBILITY_CHANGE_TIMEOUT, WINDOW } from '../../src/constants';
 import { RecordingEvent } from '../../src/types';
 import { useFakeTimers } from '../utils/use-fake-timers';
+import { PerformanceEntryResource } from './../fixtures/performanceEntry/resource';
+import { BASE_TIMESTAMP, RecordMock } from './../index';
+import { resetSdkMock } from './../mocks';
+import { DomHandler, MockTransportSend } from './../types';
 
 useFakeTimers();
 

packages/replay/test/unit/stop.test.ts

@@ -1,9 +1,9 @@
 import * as SentryUtils from '@sentry/utils';
-// mock functions need to be imported first
-import { BASE_TIMESTAMP, mockRrweb, mockSdk } from '@test';
 
 import { SESSION_IDLE_DURATION, WINDOW } from '../../src/constants';
 import { Replay } from './../../src';
+// mock functions need to be imported first
+import { BASE_TIMESTAMP, mockRrweb, mockSdk } from './../index';
 import { useFakeTimers } from './../utils/use-fake-timers';
 
 useFakeTimers();

packages/replay/test/unit/util/dedupePerformanceEntries.test.ts

@@ -1,9 +1,8 @@
 // eslint-disable-next-line import/no-unresolved
-import { PerformanceEntryLcp } from '@test/fixtures/performanceEntry/lcp';
-import { PerformanceEntryNavigation } from '@test/fixtures/performanceEntry/navigation';
-import { PerformanceEntryResource } from '@test/fixtures/performanceEntry/resource';
-
 import { dedupePerformanceEntries } from '../../../src/util/dedupePerformanceEntries';
+import { PerformanceEntryLcp } from './../../fixtures/performanceEntry/lcp';
+import { PerformanceEntryNavigation } from './../../fixtures/performanceEntry/navigation';
+import { PerformanceEntryResource } from './../../fixtures/performanceEntry/resource';
 
 it('does nothing with a single entry', function () {
   const entries = [PerformanceEntryNavigation()];

packages/replay/tsconfig.json

@@ -1,16 +1,7 @@
 {
   "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "module": "esnext",
-    "noImplicitAny": true,
-    "noEmitOnError": false,
-    "esModuleInterop": true,
-    "resolveJsonModule": true,
-    "allowJs": true,
-    "declaration": true,
-    "declarationMap": true,
-    "strictNullChecks": true
+    "module": "esnext"
   },
-  "include": ["src/**/*.ts"],
-  "exclude": ["node_modules"]
+  "include": ["src/**/*.ts"]
 }

packages/replay/tsconfig.test.json

@@ -4,17 +4,12 @@
   "include": ["test/**/*.ts", "jest.config.ts", "jest.setup.ts"],
 
   "compilerOptions": {
-    "paths": {
-      "@test": ["./test"],
-      "@test/*": ["./test/*"]
-    },
-    "baseUrl": ".",
-    "rootDir": ".",
     "types": ["node", "jest"],
-    "noImplicitAny": false,
+    "esModuleInterop": true,
+    "allowJs": true,
+    "noImplicitAny": true,
     "noImplicitThis": false,
-    "strictPropertyInitialization": false,
-    "resolveJsonModule": true,
-    "allowJs": true
+    "strictNullChecks": true,
+    "strictPropertyInitialization": false
   }
 }