Skip to content

Commit 8f44d81

Browse files
test(gatsby): Remove version test on SDK test (#4112)
Explicitly checking the SDK version on tests is a bad idea, since making new releases update the SDK version and thus tests fail.
1 parent 60c1806 commit 8f44d81

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

packages/gatsby/test/sdk.test.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,10 @@ describe('Initialize React SDK', () => {
1818
const sdkMetadata = calledWith._metadata.sdk;
1919
expect(sdkMetadata.name).toStrictEqual('sentry.javascript.gatsby');
2020
expect(sdkMetadata.version).toBe(SDK_VERSION);
21-
expect(sdkMetadata.packages).toMatchInlineSnapshot(`
22-
Array [
23-
Object {
24-
"name": "npm:@sentry/gatsby",
25-
"version": "6.13.3",
26-
},
27-
]
28-
`);
21+
expect(sdkMetadata.packages).toHaveLength(1); // Only Gatsby SDK
22+
expect(sdkMetadata.packages[0].name).toStrictEqual('npm:@sentry/gatsby');
23+
// Explicit tests on the version fail when making new releases
24+
expect(sdkMetadata.packages[0].version).toBeDefined();
2925
});
3026

3127
describe('Environment', () => {

0 commit comments

Comments
 (0)