Skip to content

test(gatsby): Remove version test on SDK test #4112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

iker-barriocanal
Copy link
Contributor

Explicitly checking the SDK version on tests is a bad idea, since making new releases update the SDK version and thus tests fail.

@iker-barriocanal iker-barriocanal requested a review from a team November 3, 2021 09:21
@iker-barriocanal iker-barriocanal self-assigned this Nov 3, 2021
@iker-barriocanal iker-barriocanal requested review from lobsterkatie and AbhiPrasad and removed request for a team November 3, 2021 09:21
@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.47 KB (0%)
@sentry/browser - Webpack 23.35 KB (0%)
@sentry/react - Webpack 23.38 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.92 KB (0%)

@iker-barriocanal iker-barriocanal merged commit 8f44d81 into master Nov 3, 2021
@iker-barriocanal iker-barriocanal deleted the iker/test/gatsby-test-version branch November 3, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants