feat(node): Make @sentry/node powered by OpenTelemetry (#10762)

This PR makes the former node-experimental package `@sentry/node`, and
the former node package `@sentry/node-experimental`.

All meta-SDKs (nextjs, sveltekit, remix, astro) as well as bun,
serverless, depend on `@sentry/node-experimental` for now. We'll need to
change this over one by one to instead depend on `@sentry/node`, and fix
any things we find along the way.

I've moved the test as much as possible, but didn't specifically invest
a lot of time to fix tests that failed - I left them to point to
node-experimental for now. This mainly affects express tests (we also
have some new express tests, but may need to port some over), and some
select others - we'll also need to investigate these one by one and
replace/update them until none are left.

Author: mydea

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/package.json

@@ -10,13 +10,11 @@
     "test:assert": "pnpm test"
   },
   "dependencies": {
-    "@sentry/node-experimental": "latest || *",
+    "@sentry/node": "latest || *",
     "@sentry/types": "latest || *",
     "@sentry/core": "latest || *",
     "@sentry/utils": "latest || *",
-    "@sentry/node": "latest || *",
-    "@sentry/opentelemetry-node": "latest || *",
-    "@sentry-internal/tracing": "latest || *",
+    "@sentry/opentelemetry": "latest || *",
     "@types/node": "18.15.1",
     "fastify": "4.23.2",
     "fastify-plugin": "4.5.1",

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/src/app.js

@@ -1,6 +1,6 @@
 require('./tracing');
 
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 const { fastify } = require('fastify');
 const fastifyPlugin = require('fastify-plugin');
 const http = require('http');

dev-packages/e2e-tests/test-applications/node-experimental-fastify-app/src/tracing.js

@@ -1,10 +1,9 @@
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   environment: 'qa', // dynamic sampling bias to keep transactions
   dsn: process.env.E2E_TEST_DSN,
   integrations: [],
-  debug: true,
   tracesSampleRate: 1,
   tunnel: 'http://localhost:3031/', // proxy server
 });

dev-packages/e2e-tests/test-applications/node-exports-test-app/package.json

@@ -12,7 +12,7 @@
     "test:assert": "pnpm test"
   },
   "dependencies": {
-    "@sentry/node": "latest || *",
+    "@sentry/node-experimental": "latest || *",
     "@sentry/sveltekit": "latest || *",
     "@sentry/remix": "latest || *",
     "@sentry/astro": "latest || *",

dev-packages/e2e-tests/test-applications/node-exports-test-app/scripts/consistentExports.ts

@@ -1,7 +1,7 @@
 import * as SentryAstro from '@sentry/astro';
 import * as SentryBun from '@sentry/bun';
 import * as SentryNextJs from '@sentry/nextjs';
-import * as SentryNode from '@sentry/node';
+import * as SentryNode from '@sentry/node-experimental';
 import * as SentryRemix from '@sentry/remix';
 import * as SentryServerless from '@sentry/serverless';
 import * as SentrySvelteKit from '@sentry/sveltekit';

dev-packages/e2e-tests/test-applications/node-express-app/src/app.ts

@@ -22,9 +22,6 @@ Sentry.init({
 const app = express();
 const port = 3030;
 
-app.use(Sentry.Handlers.requestHandler());
-app.use(Sentry.Handlers.tracingHandler());
-
 app.get('/test-success', function (req, res) {
   res.send({ version: 'v1' });
 });
@@ -73,7 +70,7 @@ app.get('/test-local-variables-caught', function (req, res) {
   res.send({ exceptionId, randomVariableToRecord });
 });
 
-app.use(Sentry.Handlers.errorHandler());
+Sentry.setupExpressErrorHandler(app);
 
 // @ts-ignore
 app.use(function onError(err, req, res, next) {

dev-packages/e2e-tests/test-applications/node-hapi-app/src/app.js

@@ -10,7 +10,6 @@ Sentry.init({
   environment: 'qa', // dynamic sampling bias to keep transactions
   dsn: process.env.E2E_TEST_DSN,
   includeLocalVariables: true,
-  integrations: [Sentry.hapiIntegration({ server })],
   debug: true,
   tunnel: `http://localhost:3031/`, // proxy server
   tracesSampleRate: 1,
@@ -56,6 +55,7 @@ const init = async () => {
 
 (async () => {
   init();
+  await Sentry.setupHapiErrorHandler(server);
   await server.start();
   console.log('Server running on %s', server.info.uri);
 })();

dev-packages/node-integration-tests/package.json

@@ -16,12 +16,9 @@
     "build:types": "tsc -p tsconfig.types.json",
     "clean": "rimraf -g **/node_modules && run-p clean:script",
     "clean:script": "node scripts/clean.js",
-    "prisma:init": "(cd suites/tracing/prisma-orm && ts-node ./setup.ts)",
-    "prisma:init:new": "(cd suites/tracing-new/prisma-orm && ts-node ./setup.ts)",
     "lint": "eslint . --format stylish",
     "fix": "eslint . --format stylish --fix",
     "type-check": "tsc",
-    "pretest": "run-s --silent prisma:init prisma:init:new",
     "test": "ts-node ./utils/run-tests.ts",
     "jest": "jest --config ./jest.config.js",
     "test:watch": "yarn test --watch"

dev-packages/node-integration-tests/suites/anr/basic-session.js

@@ -12,6 +12,7 @@ Sentry.init({
   release: '1.0',
   debug: true,
   integrations: [Sentry.anrIntegration({ captureStackTrace: true, anrThreshold: 100 })],
+  autoSessionTracking: true,
 });
 
 function longWork() {

dev-packages/node-integration-tests/suites/express/handle-error/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import express from 'express';
 
 const app = express();

dev-packages/node-integration-tests/suites/express/multiple-routers/common-infix-parameterized/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-infix/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-parameterized-reverse/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-parameterized/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-same-length-parameterized copy/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix-same-length-parameterized/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/common-prefix/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/multiple-routers/complex-router/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import express from 'express';
 
 const app = express();

dev-packages/node-integration-tests/suites/express/multiple-routers/middle-layer-parameterized/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import express from 'express';
 
 const app = express();

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-header-out/server.ts

@@ -1,6 +1,6 @@
 import http from 'http';
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-other-vendors-with-sentry-entries/server.ts

@@ -1,6 +1,6 @@
 import * as http from 'http';
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-other-vendors/server.ts

@@ -1,6 +1,6 @@
 import http from 'http';
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/sentry-trace/baggage-transaction-name/server.ts

@@ -1,7 +1,7 @@
 import http from 'http';
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
 import { SEMANTIC_ATTRIBUTE_SENTRY_SOURCE } from '@sentry/core';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/sentry-trace/server.ts

@@ -1,6 +1,6 @@
 import http from 'http';
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/express/tracing-experimental/server.js

@@ -1,5 +1,5 @@
 const { loggingTransport, startExpressServerAndSendPortToRunner } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 const cors = require('cors');
 
 Sentry.init({

dev-packages/node-integration-tests/suites/express/tracing/server.ts

@@ -1,5 +1,5 @@
 import { loggingTransport, startExpressServerAndSendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import cors from 'cors';
 import express from 'express';
 

dev-packages/node-integration-tests/suites/public-api/LocalVariables/test.ts

@@ -80,8 +80,8 @@ conditionalTest({ min: 18 })('LocalVariables integration', () => {
     child.on('message', msg => {
       reportedCount++;
       const rssMb = msg.memUsage.rss / 1024 / 1024;
-      // We shouldn't use more than 100MB of memory
-      expect(rssMb).toBeLessThan(100);
+      // We shouldn't use more than 120MB of memory
+      expect(rssMb).toBeLessThan(120);
     });
 
     // Wait for 20 seconds

dev-packages/node-integration-tests/suites/public-api/OnUncaughtException/mimic-native-behaviour-additional-listener-test-script.js

@@ -2,17 +2,11 @@ const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: integrations => {
-    return integrations.map(integration => {
-      if (integration.name === 'OnUncaughtException') {
-        return new Sentry.Integrations.OnUncaughtException({
-          exitEvenIfOtherHandlersAreRegistered: false,
-        });
-      } else {
-        return integration;
-      }
-    });
-  },
+  integrations: [
+    Sentry.onUncaughtExceptionIntegration({
+      exitEvenIfOtherHandlersAreRegistered: false,
+    }),
+  ],
 });
 
 process.on('uncaughtException', () => {

dev-packages/node-integration-tests/suites/public-api/OnUncaughtException/mimic-native-behaviour-no-additional-listener-test-script.js

@@ -2,17 +2,11 @@ const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',
-  integrations: integrations => {
-    return integrations.map(integration => {
-      if (integration.name === 'OnUncaughtException') {
-        return new Sentry.Integrations.OnUncaughtException({
-          exitEvenIfOtherHandlersAreRegistered: false,
-        });
-      } else {
-        return integration;
-      }
-    });
-  },
+  integrations: [
+    Sentry.onUncaughtExceptionIntegration({
+      exitEvenIfOtherHandlersAreRegistered: false,
+    }),
+  ],
 });
 
 setTimeout(() => {

dev-packages/node-integration-tests/suites/public-api/startTransaction/basic-usage/scenario.ts renamed to dev-packages/node-integration-tests/suites/public-api/startSpan/basic-usage/scenario.ts

@@ -12,7 +12,7 @@ Sentry.startSpan({ name: 'root_span' }, () => {
   Sentry.startSpan(
     {
       name: 'span_1',
-      data: {
+      attributes: {
         foo: 'bar',
         baz: [1, 2, 3],
       },
@@ -25,7 +25,7 @@ Sentry.startSpan({ name: 'root_span' }, () => {
 
   Sentry.startSpan({ name: 'span_3' }, () => {
     // span_4 is the child of span_3 but doesn't finish.
-    Sentry.startInactiveSpan({ name: 'span_4', data: { qux: 'quux' } });
+    Sentry.startInactiveSpan({ name: 'span_4', attributes: { qux: 'quux' } });
 
     // span_5 is another child of span_3 but finishes.
     Sentry.startSpan({ name: 'span_5' }, () => undefined);

dev-packages/node-integration-tests/suites/public-api/startTransaction/basic-usage/test.ts renamed to dev-packages/node-integration-tests/suites/public-api/startSpan/basic-usage/test.ts

@@ -1,6 +1,6 @@
 /* eslint-disable no-console */
 import type { SessionFlusher } from '@sentry/core';
-import * as Sentry from '@sentry/node';
+import * as Sentry from '@sentry/node-experimental';
 import express from 'express';
 
 const app = express();

dev-packages/node-integration-tests/suites/public-api/startTransaction/with-nested-spans/scenario.ts renamed to dev-packages/node-integration-tests/suites/public-api/startSpan/with-nested-spans/scenario.ts

@@ -1,4 +1,4 @@
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
 
 Sentry.init({

dev-packages/node-integration-tests/suites/public-api/startTransaction/with-nested-spans/test.ts renamed to dev-packages/node-integration-tests/suites/public-api/startSpan/with-nested-spans/test.ts

@@ -1,4 +1,4 @@
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
 
 Sentry.init({

dev-packages/node-integration-tests/suites/sessions/server.ts

@@ -1,5 +1,5 @@
 const { loggingTransport, sendPortToRunner } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/scenario-mutation.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/apollo-graphql/scenario-query.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/hapi/scenario.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/mongodb/scenario.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/mongoose/scenario.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/mysql/scenario-withConnect.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/mysql/scenario-withoutCallback.js

@@ -1,7 +1,7 @@
 /* eslint-disable @typescript-eslint/naming-convention */
 /* eslint-disable @typescript-eslint/explicit-member-accessibility */
 import { loggingTransport, sendPortToRunner } from '@sentry-internal/node-integration-tests';
-import * as Sentry from '@sentry/node-experimental';
+import * as Sentry from '@sentry/node';
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',

dev-packages/node-integration-tests/suites/tracing-experimental/mysql/scenario-withoutConnect.js

@@ -1,5 +1,5 @@
 const { loggingTransport } = require('@sentry-internal/node-integration-tests');
-const Sentry = require('@sentry/node-experimental');
+const Sentry = require('@sentry/node');
 
 Sentry.init({
   dsn: 'https://[email protected]/1337',