feat(node): Make @sentry/node powered by OpenTelemetry
#10762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
changed the title
@sentry/node powered by OpenTelemetry
AbhiPrasad
approved these changes
Feb 21, 2024
size-limit report 📦
|
mydea
commented
Feb 21, 2024
| @@ -80,8 +80,8 @@ conditionalTest({ min: 18 })('LocalVariables integration', () => { | |||
| child.on('message', msg => { | |||
| reportedCount++; | |||
| const rssMb = msg.memUsage.rss / 1024 / 1024; | |||
| // We shouldn't use more than 100MB of memory | |||
| expect(rssMb).toBeLessThan(100); | |||
| // We shouldn't use more than 120MB of memory | |||
There was a problem hiding this comment.
@timfish not sure how bad that is, is that just a "random" number or is the fact that this is exceeding this here a sign that it is actually leaking memory? 🤔 I would expect this to use more memory now if it's OTEL powered than before, but 🤷
There was a problem hiding this comment.
If memory is leaked, it exceeds this quite quickly. 100MB was chosen simply because it was the lowest figure where the tests would pass reliably.
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 21, 2024
This PR makes the former node-experimental package `@sentry/node`, and the former node package `@sentry/node-experimental`. All meta-SDKs (nextjs, sveltekit, remix, astro) as well as bun, serverless, depend on `@sentry/node-experimental` for now. We'll need to change this over one by one to instead depend on `@sentry/node`, and fix any things we find along the way. I've moved the test as much as possible, but didn't specifically invest a lot of time to fix tests that failed - I left them to point to node-experimental for now. This mainly affects express tests (we also have some new express tests, but may need to port some over), and some select others - we'll also need to investigate these one by one and replace/update them until none are left.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the former node-experimental package
@sentry/node, and the former node package@sentry/node-experimental.All meta-SDKs (nextjs, sveltekit, remix, astro) as well as bun, serverless, depend on
@sentry/node-experimentalfor now. We'll need to change this over one by one to instead depend on@sentry/node, and fix any things we find along the way.I've moved the test as much as possible, but didn't specifically invest a lot of time to fix tests that failed - I left them to point to node-experimental for now. This mainly affects express tests (we also have some new express tests, but may need to port some over), and some select others - we'll also need to investigate these one by one and replace/update them until none are left.