Skip to content

Commit 996d811

Browse files
committed
fix e2e tests a bit
1 parent bf75b3e commit 996d811

File tree

3 files changed

+14
-8
lines changed

3 files changed

+14
-8
lines changed

.github/workflows/build.yml

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,7 +1067,7 @@ jobs:
10671067
ref: ${{ env.HEAD_COMMIT }}
10681068
- uses: pnpm/action-setup@v4
10691069
with:
1070-
version: 8.3.1
1070+
version: 9.4.0
10711071
- name: Set up Node
10721072
uses: actions/setup-node@v4
10731073
with:
@@ -1104,12 +1104,12 @@ jobs:
11041104
- name: Build E2E app
11051105
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
11061106
timeout-minutes: 5
1107-
run: yarn ${{ matrix.build-command || 'test:build' }}
1107+
run: pnpm ${{ matrix.build-command || 'test:build' }}
11081108

11091109
- name: Run E2E test
11101110
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
11111111
timeout-minutes: 5
1112-
run: yarn test:assert
1112+
run: pnpm test:assert
11131113

11141114
- name: Deploy Astro to Cloudflare
11151115
uses: cloudflare/pages-action@v1
@@ -1152,14 +1152,18 @@ jobs:
11521152
]
11531153
build-command:
11541154
- false
1155+
assert-command:
1156+
- false
11551157
label:
11561158
- false
11571159
include:
11581160
- test-application: 'create-remix-app'
11591161
build-command: 'test:build-sourcemaps'
1162+
assert-command: 'test:assert-sourcemaps'
11601163
label: 'create-remix-app (sourcemaps)'
11611164
- test-application: 'create-remix-app-legacy'
11621165
build-command: 'test:build-sourcemaps'
1166+
assert-command: 'test:assert-sourcemaps'
11631167
label: 'create-remix-app-legacy (sourcemaps)'
11641168

11651169
steps:
@@ -1169,7 +1173,7 @@ jobs:
11691173
ref: ${{ env.HEAD_COMMIT }}
11701174
- uses: pnpm/action-setup@v4
11711175
with:
1172-
version: 8.3.1
1176+
version: 9.4.0
11731177
- name: Set up Node
11741178
uses: actions/setup-node@v4
11751179
with:
@@ -1203,12 +1207,12 @@ jobs:
12031207
- name: Build E2E app
12041208
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
12051209
timeout-minutes: 5
1206-
run: yarn ${{ matrix.build-command || 'test:build' }}
1210+
run: pnpm ${{ matrix.build-command || 'test:build' }}
12071211

12081212
- name: Run E2E test
12091213
working-directory: dev-packages/e2e-tests/test-applications/${{ matrix.test-application }}
12101214
timeout-minutes: 5
1211-
run: yarn test:assert
1215+
run: pnpm ${{ matrix.assert-command || 'test:assert' }}
12121216

12131217
job_profiling_e2e_tests:
12141218
name: E2E ${{ matrix.label || matrix.test-application }} Test

dev-packages/e2e-tests/test-applications/create-remix-app-legacy/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1111
"test:build": "pnpm install && npx playwright install && pnpm build",
1212
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
13-
"test:assert": "pnpm playwright test"
13+
"test:assert": "pnpm playwright test",
14+
"test:assert-sourcemaps": "pnpm -v"
1415
},
1516
"dependencies": {
1617
"@sentry/remix": "latest || *",

dev-packages/e2e-tests/test-applications/create-remix-app/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
"clean": "npx rimraf node_modules pnpm-lock.yaml",
1111
"test:build": "pnpm install && npx playwright install && pnpm build",
1212
"test:build-sourcemaps": "pnpm install && npx playwright install && pnpm build && pnpm upload-sourcemaps",
13-
"test:assert": "pnpm playwright test"
13+
"test:assert": "pnpm playwright test",
14+
"test:assert-sourcemaps": "pnpm -v"
1415
},
1516
"dependencies": {
1617
"@sentry/remix": "latest || *",

0 commit comments

Comments
 (0)