Skip to content

Commit b4f927b

Browse files
committed
fix url check
1 parent a4419c2 commit b4f927b

File tree

2 files changed

+3
-3
lines changed
  • dev-packages/browser-integration-tests

2 files changed

+3
-3
lines changed

dev-packages/browser-integration-tests/suites/tracing/request/fetch-with-no-active-span/test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { expect } from '@playwright/test';
22

33
import { sentryTest } from '../../../../utils/fixtures';
4-
import { shouldSkipTracingTest } from '../../../../utils/helpers';
4+
import { envelopeUrlRegex, shouldSkipTracingTest } from '../../../../utils/helpers';
55

66
sentryTest(
77
'there should be no span created for fetch requests with no active span',
@@ -14,7 +14,7 @@ sentryTest(
1414

1515
let requestCount = 0;
1616
page.on('request', request => {
17-
expect(request.url()).not.toContain(url);
17+
expect(envelopeUrlRegex.test(request.url())).toBe(false);
1818
requestCount++;
1919
});
2020

dev-packages/browser-integration-tests/utils/helpers.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import type { Page, Request } from '@playwright/test';
22
import type { EnvelopeItemType, Event, EventEnvelopeHeaders } from '@sentry/types';
33

4-
const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//;
4+
export const envelopeUrlRegex = /\.sentry\.io\/api\/\d+\/envelope\//;
55

66
export const envelopeParser = (request: Request | null): unknown[] => {
77
// https://develop.sentry.dev/sdk/envelopes/

0 commit comments

Comments
 (0)